Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Pointer & Geopoint support, added more features to Query #21

Merged
merged 71 commits into from
Oct 16, 2020

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Sep 14, 2020

  • Added Pointers and deep save of child objects
  • Added full GeoPoint support along with querying based on a geopoint or proximity. Also added test cases and documentation
  • Added more capabilities to Query. The Swift SDK can now do almost everything the JS SDK can do in terms of querying. Support for aggregate is still missing
  • Added GeoPoint demo to playgrounds
  • Bump Xcode environment in CI from Xcode 11.6 to Xcode 11.7
  • Switched ParseEncoder which is a rip and mod of the JSONEncoder from open-source Swift 5.3

@cbaker6 cbaker6 marked this pull request as draft September 14, 2020 21:34
@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #21 into main will decrease coverage by 2.70%.
The diff coverage is 55.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   64.91%   62.20%   -2.71%     
==========================================
  Files          29       31       +2     
  Lines        1485     2326     +841     
==========================================
+ Hits          964     1447     +483     
- Misses        521      879     +358     
Impacted Files Coverage Δ
Sources/ParseSwift/API/BatchUtils.swift 63.63% <ø> (ø)
Sources/ParseSwift/API/Responses.swift 60.71% <0.00%> (-39.29%) ⬇️
Sources/ParseSwift/Coding/Extensions.swift 66.66% <ø> (+33.33%) ⬆️
Sources/ParseSwift/Coding/ParseCoding.swift 87.23% <ø> (ø)
...arseSwift/Object Protocols/ParseInstallation.swift 90.99% <0.00%> (ø)
...seSwift/Object Protocols/Protocols/Deletable.swift 0.00% <0.00%> (ø)
...seSwift/Object Protocols/Protocols/Fetchable.swift 0.00% <ø> (ø)
...seSwift/Object Protocols/Protocols/Queryable.swift 0.00% <ø> (ø)
...rseSwift/Object Protocols/Protocols/Saveable.swift 0.00% <ø> (ø)
Sources/ParseSwift/Parse Types/ACL.swift 88.03% <ø> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d77060...bb0d125. Read the comment docs.

@cbaker6 cbaker6 marked this pull request as ready for review September 21, 2020 21:21
@cbaker6
Copy link
Contributor Author

cbaker6 commented Sep 21, 2020

@pranjalsatija can you review this?

@cbaker6
Copy link
Contributor Author

cbaker6 commented Sep 23, 2020

@TomWFox I added a decent amount of documentation here, can you look it over and make any necessary changes you see?

Note that in some places, I opted to make Query and GeoPoint look more like the JS SDK instead of the obj-c one. This framework probably has more querying ability than the obj-c one now, but is still slightly behind the JS one, but I'll fix that in a different PR. Also, because of the "typeness" of Swift, I couldn't think of a good way to return standard JSON when using explain and hint when using the methods that were already in place (at least without breaking and making it look ugly). Instead, I opted to make find, first, and count have an "explainable and hintable" methods

@cbaker6 cbaker6 marked this pull request as draft October 7, 2020 23:54
@cbaker6 cbaker6 changed the title Geopoint support Added Pointer & Geopoint support, added more features to Query Oct 8, 2020
@cbaker6 cbaker6 marked this pull request as ready for review October 8, 2020 15:03
@cbaker6
Copy link
Contributor Author

cbaker6 commented Oct 8, 2020

Codecov dropped in this PR due to the addition of the new ParseEncoder. It's basically a mod of the native JSON encoder, so the components that are unit tested are the added Parse-Swift ones.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Oct 12, 2020

I managed to use Parse-Swift to replace the obj-c framework in one of my sample apps where objc-parse was already working great. This is how found most of the bugs.

This framework can definitely handle the basics after this PR is merged

@cbaker6
Copy link
Contributor Author

cbaker6 commented Oct 12, 2020

@TomWFox I'm finished with changes/debugging. Can you review the added documentation?

Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation proofread ✅

@TomWFox
Copy link
Contributor

TomWFox commented Oct 16, 2020

Btw you can't merge this because codecov/patch is a required check but I could remove this requirement or you could lower the coverage target.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Oct 16, 2020

@TomWFox i can lower the reqs for codecov patch in the .codecov file (I think) and then increase it on the next PR.

@TomWFox
Copy link
Contributor

TomWFox commented Oct 16, 2020

Sounds good.

@cbaker6 cbaker6 merged commit 25edf7f into main Oct 16, 2020
@cbaker6 cbaker6 deleted the geopoint branch October 16, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants