-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Pointer & Geopoint support, added more features to Query #21
Conversation
cbaker6
commented
Sep 14, 2020
•
edited
Loading
edited
- Added Pointers and deep save of child objects
- Added full GeoPoint support along with querying based on a geopoint or proximity. Also added test cases and documentation
- Added more capabilities to Query. The Swift SDK can now do almost everything the JS SDK can do in terms of querying. Support for aggregate is still missing
- Added GeoPoint demo to playgrounds
- Bump Xcode environment in CI from Xcode 11.6 to Xcode 11.7
- Switched ParseEncoder which is a rip and mod of the JSONEncoder from open-source Swift 5.3
Codecov Report
@@ Coverage Diff @@
## main #21 +/- ##
==========================================
- Coverage 64.91% 62.20% -2.71%
==========================================
Files 29 31 +2
Lines 1485 2326 +841
==========================================
+ Hits 964 1447 +483
- Misses 521 879 +358
Continue to review full report at Codecov.
|
@pranjalsatija can you review this? |
…ose to the UnitTests as the unit tests require a mock CoreLocation
…straints, added more examples to playgrounds. Also added more documentation
@TomWFox I added a decent amount of documentation here, can you look it over and make any necessary changes you see? Note that in some places, I opted to make Query and GeoPoint look more like the JS SDK instead of the obj-c one. This framework probably has more querying ability than the obj-c one now, but is still slightly behind the JS one, but I'll fix that in a different PR. Also, because of the "typeness" of Swift, I couldn't think of a good way to return standard JSON when using |
…hey are not working with an actual parse-server
…sn't needed. Saves during deep save are done 1 by 1 until batch is fixed.
Codecov dropped in this PR due to the addition of the new ParseEncoder. It's basically a mod of the native JSON encoder, so the components that are unit tested are the added Parse-Swift ones. |
Carthage runs on Xcode 11.7 because it has issue with Xcode 12
…g custom encoding/decoding on a parse object
…d be turned into a pointer
I managed to use Parse-Swift to replace the obj-c framework in one of my sample apps where objc-parse was already working great. This is how found most of the bugs. This framework can definitely handle the basics after this PR is merged |
@TomWFox I'm finished with changes/debugging. Can you review the added documentation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation proofread ✅
Btw you can't merge this because codecov/patch is a required check but I could remove this requirement or you could lower the coverage target. |
@TomWFox i can lower the reqs for codecov patch in the .codecov file (I think) and then increase it on the next PR. |
Sounds good. |