fix: always sort JSON encoded keys #318
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
When using the SDK encoders, the keys are not required to be sorted. Since a JSON encoded string is sometimes used a keys or compared directly internally, it can lead to matches not found when saving
ParseObject
's that have childrenParseObect
's.This is also the reason why multiple tests are disabled for Linux and Windows.
Related issue: #n/a
Approach
Make all SDK encoders sort keys.
TODOs before merging