-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: user Swift convention for parameter names #321
Conversation
Thanks for opening this pull request!
|
Codecov Report
@@ Coverage Diff @@
## main #321 +/- ##
==========================================
- Coverage 84.98% 84.96% -0.02%
==========================================
Files 114 114
Lines 12049 12049
==========================================
- Hits 10240 10238 -2
- Misses 1809 1811 +2
Continue to review full report at Codecov.
|
@pmmlo can you look at this? I'm attempting to make the method signatures more swifty |
Looks great! What an annoying refactor 😵💫 |
I feel like these are always tricky to get right the first time. Since we have to introduce breaks in 4.0.0, might as well get them out of the way now. I'm going to merge this one, but if you see other changes like this that should be made, can you open some PR's? |
Makes a lot of sense. Will try my best to help as I see them. Thanks very much for another great release candidate! |
New Pull Request Checklist
Issue Description
Some naming in the SDK doesn't match Swift Style guide
Related issue: #n/a
Approach
Move to matching Swift Style Guide. Breaking, but the compiler should get most of these correct. Many people are probably not using most of these as they have default values...
Makes the following changes:
isUsingMongoDB -> usingMongoDB
isIgnoreCustomObjectIdConfig -> ignoringCustomObjectIdConfig
isUsingEQ -> usingEqComparator
TODOs before merging