feat: allow any dimension value for ParseAnalytics #341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
Dimension values currently can only be
String
type. This use to be the requirement for the original Parse Server, but some analytics adapters can support types other than String. The Swift Client should allow any type of dimension value.Also the developer should be responsible for requesting tracking authorization when sending analytics to other companies instead of the SDK.
Related issue: #n/a
Approach
Let the OS and developer decide if app tracking authorization is required when using
ParseAnalytics
.ParseAnalytics
can now take anyCodable
value in its'dimensions
instead of just strings. Added a new propertydate
toParseAnalytics
. Theat
property will be deprecated in ParseSwift 5.0.0, so developers should switch todate
.ParseAnalytics
can now be properly decoded after encoding with aJSONEncoder
. This is useful ifParseAnalytics
type need to be stored locally and sent to the server later.TODOs before merging