Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add macCatalyst to SPM #363

Merged
merged 3 commits into from
May 17, 2022
Merged

feat: add macCatalyst to SPM #363

merged 3 commits into from
May 17, 2022

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented May 17, 2022

New Pull Request Checklist

Issue Description

macCatalyst isn't specified in Package.swift. The Xcode 13.4 release notes mentions this can cause an issue:

Swift Playgrounds app projects with package dependencies fail to build for Mac Catalyst when a package specifies .iOS(...) in its platforms array in the manifest, but doesn’t specify .macCatalyst(...)

Related issue: #n/a

Approach

Add macCatalyst to Package.swift.

TODOs before merging

  • Add entry to changelog

@parse-github-assistant
Copy link

parse-github-assistant bot commented May 17, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #363 (3d50b73) into main (9a3de84) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   87.90%   87.90%   -0.01%     
==========================================
  Files         114      114              
  Lines       12207    12207              
==========================================
- Hits        10731    10730       -1     
- Misses       1476     1477       +1     
Impacted Files Coverage Δ
Sources/ParseSwift/Objects/ParseObject.swift 84.73% <0.00%> (-0.31%) ⬇️
Sources/ParseSwift/Coding/ParseEncoder.swift 77.77% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a3de84...3d50b73. Read the comment docs.

@cbaker6 cbaker6 merged commit a3d9018 into parse-community:main May 17, 2022
@cbaker6 cbaker6 deleted the calalyst branch May 17, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant