Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update keychains of ParseUser and ParseInstallation #38

Merged
merged 11 commits into from
Dec 22, 2020
Merged

Update keychains of ParseUser and ParseInstallation #38

merged 11 commits into from
Dec 22, 2020

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Dec 20, 2020

In order to get this, User and Installation protocols have to implement it's own versions of some of the ParseObject methods. Not necessarily a problem, but adds more code to the ParseUser and ParseInstallation protocols. Also requires some additional testing outside of the ParseObject tests of these methods.

  • updates keychain during fetch (Close User.current not returning all variables #37), fetchAll, delete, deleteAll
  • add default callbackQueues to async Queries so user doesn't need to specify them
  • Bug fix: during a synchronous save of a ParseObject if the parse-server returned a ParseError, the framework wouldn't complete on the current thread properly.

@codecov
Copy link

codecov bot commented Dec 20, 2020

Codecov Report

Merging #38 (5f636d9) into main (e2dde15) will increase coverage by 1.22%.
The diff coverage is 80.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   71.64%   72.87%   +1.22%     
==========================================
  Files          30       30              
  Lines        1862     2127     +265     
==========================================
+ Hits         1334     1550     +216     
- Misses        528      577      +49     
Impacted Files Coverage Δ
...seSwift/Object Protocols/Protocols/Deletable.swift 0.00% <0.00%> (ø)
...seSwift/Object Protocols/Protocols/Fetchable.swift 0.00% <0.00%> (ø)
...seSwift/Object Protocols/Protocols/Queryable.swift 0.00% <0.00%> (ø)
...rseSwift/Object Protocols/Protocols/Saveable.swift 0.00% <0.00%> (ø)
...ources/ParseSwift/Object Protocols/ParseUser.swift 80.16% <79.75%> (-0.30%) ⬇️
...arseSwift/Object Protocols/ParseInstallation.swift 87.54% <83.12%> (-3.61%) ⬇️
...rces/ParseSwift/Object Protocols/ParseObject.swift 77.24% <88.23%> (-1.30%) ⬇️
Sources/ParseSwift/Parse Types/Query.swift 87.68% <100.00%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2dde15...5f636d9. Read the comment docs.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Dec 20, 2020

@pranjalsatija can you review this?

@vdkdamian
Copy link
Contributor

Any news?

@cbaker6 cbaker6 merged commit db391a4 into main Dec 22, 2020
@cbaker6 cbaker6 deleted the updates branch December 22, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User.current not returning all variables
2 participants