-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow url async calls to run in parallel #394
Conversation
Thanks for opening this pull request!
|
@vdkdamian can you try this branch out and let me know if you still see the issue you had? |
Codecov Report
@@ Coverage Diff @@
## main #394 +/- ##
==========================================
+ Coverage 89.28% 89.72% +0.43%
==========================================
Files 157 157
Lines 14970 15072 +102
==========================================
+ Hits 13366 13523 +157
+ Misses 1604 1549 -55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Yes, give me some time. I'll try it as fast as possible |
New Pull Request Checklist
Issue Description
Since async/await calls were introduced it made it a lot easier developers to make many async calls in parallel. Depending on how these async calls are made it's possible there can be a race condition in session delegates.
Also fixes a memory leak issue with Parse URL Session.
Related issue: #347
Approach
Use an
actor
for the url session delegates to ensure thread safety.The updates make the test suite pass Xcode 14 beta 5 & 6.
TODOs before merging