-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add become installation method & fix loginUsingObjCKeychain #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
Codecov Report
@@ Coverage Diff @@
## main #407 +/- ##
==========================================
- Coverage 89.94% 89.92% -0.02%
==========================================
Files 158 158
Lines 15175 15266 +91
==========================================
+ Hits 13649 13728 +79
- Misses 1526 1538 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cbaker6
changed the title
fix: login with ObjC keychain
feat: add a copy installation method and fix loginUsingObjCKeychain
Sep 11, 2022
cbaker6
changed the title
feat: add a copy installation method and fix loginUsingObjCKeychain
feat: add become installation method & fix loginUsingObjCKeychain
Sep 12, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
#391 added some migration methods but they currently have some issues:
ParseInstallation
to become anotherParseInstallation
. Adding a method like this allows developers to use their own ways to get a particularobjectId
and use it to migrate to the Swift SDK.ParseUser.loginUsingObjCKeychain
does not properly get the session token from an Objective-C Keychain.Related issue: #n/a
Approach
become
method which allows the current installation to become any installation based on theobjectId
.currentUser->sessionToken
to get thesessionToken
properly.TODOs before merging