Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SPM Issue: Remove duplicate playground page #69

Merged
merged 3 commits into from
Jan 26, 2021
Merged

Fix SPM Issue: Remove duplicate playground page #69

merged 3 commits into from
Jan 26, 2021

Conversation

pmmlo
Copy link
Contributor

@pmmlo pmmlo commented Jan 26, 2021

  • Remove playground duplicate line: <page name='10 - Cloud Code'/>

Fix #68

- Remove duplicate `<page name='10 - Cloud Code'/>`
@pmmlo
Copy link
Contributor Author

pmmlo commented Jan 26, 2021

@cbaker6 This is pretty funny, if it works. Could you try this?

@cbaker6
Copy link
Contributor

cbaker6 commented Jan 26, 2021

This works!

@cbaker6
Copy link
Contributor

cbaker6 commented Jan 26, 2021

We will need to release a new version in order to not have people download the broken one

@pmmlo
Copy link
Contributor Author

pmmlo commented Jan 26, 2021

Cheers! Whatever you think is best. It'd be really cool, if you could push it tonight. I'm playing around with CloudCode for the first time in a while and wanted to test it out on the latest!

You can also merge the fix yourself and close this PR, if that'll make things go faster. I don't care for the credit and you've done all the work.

@cbaker6
Copy link
Contributor

cbaker6 commented Jan 26, 2021

@pmmlo are you good with your name in the changelog? That's what I see on Github. Feel free to change it if you want.

@pmmlo
Copy link
Contributor Author

pmmlo commented Jan 26, 2021

@pmmlo are you good with your name in the changelog? That's what I see on Github. Feel free to change it if you want.

It'd be cool if it weren't included, but not a big deal at the end of the day.

Serious thanks for all of your work and all. Also, huge congrats on v1.0.0! This SDK sat experimental for ages. You're a rockstar.

@cbaker6
Copy link
Contributor

cbaker6 commented Jan 26, 2021

Serious thanks for all of your work and all. Also, huge congrats on v1.0.0! This SDK sat experimental for ages. You're a rockstar.

🙏🏿

@cbaker6 cbaker6 merged commit 8ed70f2 into parse-community:main Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPM Broken on v1.1.0+ and branch main
2 participants