Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve acl #80

Merged
merged 2 commits into from
Feb 16, 2021
Merged

Improve acl #80

merged 2 commits into from
Feb 16, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Feb 15, 2021

  • Minimize calls to current user
  • setDefaultACL will now throw an error if you attempt to use it with no current user logged in
  • Improve docs to reflect actual use case

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #80 (86ace5b) into main (0d81cd4) will decrease coverage by 0.21%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   79.13%   78.92%   -0.22%     
==========================================
  Files          63       63              
  Lines        5018     5020       +2     
==========================================
- Hits         3971     3962       -9     
- Misses       1047     1058      +11     
Impacted Files Coverage Δ
Sources/ParseSwift/Types/ParseACL.swift 86.09% <81.25%> (-5.86%) ⬇️
Sources/ParseSwift/Objects/ParseObject.swift 75.94% <0.00%> (-0.29%) ⬇️
Sources/ParseSwift/Objects/ParseUser.swift 75.97% <0.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d81cd4...86ace5b. Read the comment docs.

@cbaker6 cbaker6 merged commit 40ffa99 into main Feb 16, 2021
@cbaker6 cbaker6 deleted the improveACL branch February 16, 2021 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants