Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AppleAuthentication #81

Merged
merged 6 commits into from
Feb 18, 2021
Merged

Improve AppleAuthentication #81

merged 6 commits into from
Feb 18, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Feb 16, 2021

When using Apple Sign In, the identityToken is provide as type Data. This fix allows ParseAuthentication to accept the identityToken directly instead of requiring the developer to convert it.

  • Add fix
  • Update test cases

@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #81 (732d877) into main (40ffa99) will decrease coverage by 0.19%.
The diff coverage is 57.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   78.94%   78.74%   -0.20%     
==========================================
  Files          63       63              
  Lines        5020     5039      +19     
==========================================
+ Hits         3963     3968       +5     
- Misses       1057     1071      +14     
Impacted Files Coverage Δ
...rseSwift/Authentication/3rd Party/ParseApple.swift 65.97% <57.57%> (-9.67%) ⬇️
Sources/ParseSwift/Objects/ParseObject.swift 75.94% <0.00%> (-0.29%) ⬇️
Sources/ParseSwift/Objects/ParseUser.swift 76.14% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40ffa99...732d877. Read the comment docs.

@cbaker6 cbaker6 merged commit 8cee8aa into main Feb 18, 2021
@cbaker6 cbaker6 deleted the improveAppleAuth branch February 18, 2021 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant