Skip to content

Using the encoder on state is too broad. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2017
Merged

Using the encoder on state is too broad. #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ParseLiveQuery/src/main/java/com/parse/SubscribeClientOperation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,14 @@
jsonObject.put("requestId", requestId);
jsonObject.put("sessionToken", sessionToken);

JSONObject queryJsonObject = state.toJSON(PointerEncoder.get());
JSONObject queryJsonObject = new JSONObject();
queryJsonObject.put("className", state.className());

// TODO: add support for fields
// https://github.com/ParsePlatform/parse-server/issues/3671

PointerEncoder pointerEncoder = PointerEncoder.get();
queryJsonObject.put("where", pointerEncoder.encode(state.constraints()));

jsonObject.put("query", queryJsonObject);

Expand Down
2 changes: 1 addition & 1 deletion ParseLiveQuery/src/test/java/com/parse/TestParseLiveQueryClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ public void testUnsubscribeWhenSubscribedToCallback() throws Exception {
@Test
public void testErrorWhileSubscribing() throws Exception {
ParseQuery.State state = mock(ParseQuery.State.class);
when(state.toJSON(any(ParseEncoder.class))).thenThrow(new RuntimeException("forced error"));
when(state.constraints()).thenThrow(new RuntimeException("forced error"));

ParseQuery.State.Builder builder = mock(ParseQuery.State.Builder.class);
when(builder.build()).thenReturn(state);
Expand Down