Updating build in preparation for iOS 13 update.

[noobs2ninjas]

This contains changes for issue #194 and is preparation for issue #209.

[noobs2ninjas]

Finally! After SEVERAL HOURS I found out the whole reason nothing worked is because the latest version of Jazzy 0.11.0 is broken and xcodebuild_arguments doesnt work. Anyway, this is finally passing and should be everything we need to build for xcode 11/iOS 13

[drdaz]

Nailed it.

Can I get push access to your repo @noobs2ninjas?

[drdaz]

So it looks like I had push access. I pushed, and now CI can't check the code out 😩

[drdaz]

Æh.

Something to do with ruby on the CI environment it seems... I didn't change anything in the source to alter this afaik.

[drdaz]

CircleCI is ignoring the .ruby-version file on this PR for some reason. It's set to 2.6.3, but the server is trying to set it to something older and failing.

If anybody knows the right way to touch it up to make it happy, please do. Pretty sure the tests would work if they could run 😃

[drdaz]

Boom! 🙂

[drdaz]

I think we're good to go here now.

Once @TomWFox has given this another look, can we push a release? This has been incompatible with the main SDK for a really long time.

EDIT: It seems I bumped the minor version number for no reason at all. sigh

[TomWFox]

Nice work, looks ok to me, love to see those green ticks 😍

Only query I have is why has the Facebook-objc-SDK been added to the Carthage config? - apologies if it’s already been mentioned but I haven’t been able to keep up with the whole thread!

[TomWFox]

Also, As you’ve bumped the version number it would make sense to do the changelog in this pr too.

[drdaz]

Nice work, looks ok to me, love to see those green ticks 😍

Only query I have is why has the Facebook-objc-SDK been added to the Carthage config? - apologies if it’s already been mentioned but I haven’t been able to keep up with the whole thread!

It hasn't been added to the Carthage config; the Cartfile doesn't contain it. It presumably gets resolved as a dependency of the main SDK. This wasn't happening previously?

Also, As you’ve bumped the version number it would make sense to do the changelog in this pr too.

That would make sense I guess. I'll see if I can figure that out.

[TomWFox]

True, it shows up in the cartfile.resolved and the .gitmodules files. I don’t think it should be a dependency of the main SDK only the parseui and Facebook-Utils submodules?

[drdaz]

True, it shows up in the cartfile.resolved and the .gitmodules files. I don’t think it should be a dependency of the main SDK only the parseui and Facebook-Utils submodules?

Carthage doesn't support submodules, sadly. So the way the main SDK is structured, using Carthage, you get the whole shebang, dependencies and all.

[TomWFox]

Got it, never used Carthage so it's workings baffle me somewhat. I've just made fix and a couple changes to the changelog to bring it in line with other repos.