Implement ParseQueryPager #129
Conversation
|
By analyzing the blame information on this pull request, we identified @wangmengyan95 and @grantland to be potential reviewers. |
|
@grantland updated the pull request. |
1 similar comment
|
@grantland updated the pull request. |
| setPageOnQuery(page, query); | ||
| private void loadNextPage(final boolean shouldClear) { | ||
| if (shouldClear && pager != null) { | ||
| cts.cancel(); |
There was a problem hiding this comment.
Since we set cts to null in clear(), do we need null checking for cts here?
There was a problem hiding this comment.
We don't, but you made me realized we need synchronized (lock) here
|
@grantland updated the pull request. |
| @Override | ||
| public Task<List<T>> then(Task<List<T>> task) throws Exception { | ||
| synchronized (lock) { | ||
| loadNextPageTask = null; |
There was a problem hiding this comment.
Why we need to clear loadNextPageTask here, does this prevent us from calling loadNextPageTask multiple times?
There was a problem hiding this comment.
It's what we use to determine isLoadingNextPage()
A utility class to page through `ParseQuery` results
grantland
force-pushed
the
grantland.pager
branch
from
8504d1d to
e9af63f
Compare
|
When will ParseQueryPager be available via |
|
@wangmengyan95 might be worthwhile to do a release at some point? |
A utility class to page through
ParseQueryresults