-
-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL Customisation #652
GraphQL Customisation #652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for taking the time to do this! Just a few changes I can see immediately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new section needs to be added to the graphql.md file so that it is added to the guide when the docs are built.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I like the way you explained. Additionally to @TomWFox comments, I added some other few suggestions. The rest seems good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added all the suggestions from above - @davimacedo I've switched everything to javascript except line 16 given that it's using the interface
structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me
* commit 'e129790ed587819ecfcaed59fc7ff90ec6ffcfa1': (84 commits) Add `cascadeSave` option in ParseObject to JS docs (parse-community#664) Update apple sign in documentation (parse-community#662) Bump mixin-deep from 1.3.1 to 1.3.2 (parse-community#670) Update GraphQL docs with latest changes (parse-community#669) remove a bunch of parse cloud references (parse-community#654) docs: fixed examples for pipeline in aggregation (parse-community#661) Add beta notice to the GraphQL Guide (parse-community#659) iOS Documentation Revamp (parse-community#650) Fix doc for creating a subscription in javascript (parse-community#658) GraphQL Customisation (parse-community#652) added PhantAuth authData docs (parse-community#655) Fix typo in keys.md (parse-community#656) Fix typo in cloud-code.md (parse-community#657) add reference to afterFind, add more detail on predefined classes (parse-community#653) Add `keys` and `excludeKeys` options to REST docs (parse-community#649) document push type and priority keys for notifications (parse-community#639) Documentation for Sign In With Apple (parse-community#648) Documentation for isDataAvailable (parse-community#647) Remove line for 3.x (parse-community#646) Add documentation for query.withCount (parse-community#645) ...
This is a guide for the GraphQL Config feature but I have placed it under the header "Customisation". I think this would be an appropriate place to also add docs for this PR