Skip to content

GraphQL Docs for Parse Server 3.10.0 #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 43 commits into from
Jan 12, 2020
Merged

GraphQL Docs for Parse Server 3.10.0 #688

merged 43 commits into from
Jan 12, 2020

Conversation

Moumouls
Copy link
Member

@Moumouls Moumouls commented Nov 30, 2019 •
edited
Loading

GraphQL Doc

@Moumouls Moumouls mentioned this pull request Nov 30, 2019
Merged
TomWFox
TomWFox reviewed Dec 2, 2019
View reviewed changes
Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! This is what I've got so far...

General notes:

  • Perhaps ease up on the bold formatting
  • Maybe run a spell check - I've highlighted some but I'm sure I've missed others

@Moumouls
Copy link
Member Author

Moumouls commented Dec 2, 2019

@TomWFox yes i need support of a native english contributor on this doc. I'm French (Baguette) so it's not the best English you can find right now 😄

Could you help on this ?

With my last commit, i think that we have a good start, but tomorrow is my last Open Source Day of the week, and i want to work on missing features of the GraphQL implementation...

@omairvaiyani @davimacedo

Moumouls and others added 18 commits December 2, 2019 18:53
@Moumouls @TomWFox
Update _includes/graphql/users.md
d46021c 
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@Moumouls @TomWFox
Update _includes/graphql/classes.md
6973cb9 
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@Moumouls @TomWFox
Update _includes/graphql/relay.md
655f7a0 
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@Moumouls @TomWFox
Update _includes/graphql/files.md
a981385 
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@Moumouls @TomWFox
Update _includes/graphql/files.md
2fc85d3 
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@Moumouls @TomWFox
Update _includes/graphql/getting-started.md
80ae6be 
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@Moumouls @TomWFox
Update _includes/graphql/relay.md
74dbbbe 
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@Moumouls @TomWFox
Update _includes/graphql/graphql.md
4cf995f 
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@Moumouls @TomWFox
Update _includes/graphql/relay.md
0445972 
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@Moumouls @TomWFox
Update _includes/graphql/relay.md
dceac2f 
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@Moumouls @TomWFox
Update _includes/graphql/getting-started.md
4ad78dd 
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@Moumouls @TomWFox
Update _includes/graphql/graphql.md
93b4aa9 
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@Moumouls @TomWFox
Update _includes/graphql/objects.md
e76b5db 
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@Moumouls @TomWFox
Update _includes/graphql/objects.md
0b91812 
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@Moumouls @TomWFox
Update _includes/graphql/queries.md
54782cc 
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@Moumouls @TomWFox
Update _includes/graphql/objects.md
e0e3171 
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@Moumouls @TomWFox
Update _includes/graphql/objects.md
bfeec9c 
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@Moumouls @TomWFox
Update _includes/graphql/queries.md
59efa78 
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@Moumouls
Copy link
Member Author

Moumouls commented Dec 2, 2019

@TomWFox thanks for the first review ! 😃

@Moumouls @TomWFox
Apply suggestions from code review
f6feced 
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@Moumouls
Copy link
Member Author

Moumouls commented Dec 7, 2019

@TomWFox it's strange, i sent batch commit but still conserve Changes requested state...

@Moumouls Moumouls requested a review from TomWFox December 7, 2019 16:27
@davimacedo
Copy link
Member

@TomWFox Since 3.10 was launched with the breaking changes, it is important to release this update ASAP. Can I merge and we can do any correction/improvement later?

@TomWFox
Copy link
Contributor

TomWFox commented Jan 9, 2020 •
edited
Loading

Ah ok, I didn't realise we were going for a 3.10 release, there are definitely still changes to be made but I think its mainly grammatical stuff so its not the end of the world to merge now

@Moumouls
Copy link
Member Author

Moumouls commented Jan 9, 2020

Please just make a last spell check (due to my french English ☺️) then we can merge !

@TomWFox
Copy link
Contributor

TomWFox commented Jan 9, 2020

I can do that tomorrow.

TomWFox
TomWFox suggested changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked 7 of 17 files so far, here is what I have, I'll get to the rest later.

TomWFox
TomWFox suggested changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's some more, @Moumouls if its ok with you I think it would be much quicker for me to make commits with changes directly.

Moumouls and others added 5 commits January 10, 2020 23:27
@Moumouls @TomWFox
Apply suggestions from code review
d67699a 
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@Moumouls @TomWFox
Update _includes/graphql/optimization.md
559ccd8 
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@TomWFox
Update queries.md
3f8298f
@TomWFox
minor changes
2fd6b2d
@TomWFox
change from previous review comment
f28d38c
@TomWFox
Copy link
Contributor

TomWFox commented Jan 12, 2020

@Moumouls I've unresolved the earlier review comments from @omairvaiyani that you marked as resolved because I checked the first two and the changes haven't been applied.

Could you apply the suggestions or discuss with Omair if you disagree?

@TomWFox TomWFox self-requested a review January 12, 2020 16:34
TomWFox
TomWFox approved these changes Jan 12, 2020
View reviewed changes
Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I've applied all the suggestions (or similar) from @omairvaiyani, checked all the files and made any changes I thought were necessary and I've built the site and its looking ok.

So... I think this is good enough to merge!

@TomWFox TomWFox merged commit 3341e7b into parse-community:gh-pages Jan 12, 2020
@TomWFox TomWFox changed the title WIP: GraphQL Docs GraphQL Docs for Parse Server 3.10.0 Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omairvaiyani omairvaiyani omairvaiyani requested changes

@davimacedo davimacedo davimacedo approved these changes

@TomWFox TomWFox TomWFox approved these changes

Assignees
No one assigned
Labels
docs:graphql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Moumouls @TomWFox @davimacedo @omairvaiyani