feat: Add support for Live Activity with ActivityKit push notifications #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #130 +/- ##
==========================================
+ Coverage 93.42% 93.53% +0.11%
==========================================
Files 23 23
Lines 578 588 +10
==========================================
+ Hits 540 550 +10
Misses 38 38
☔ View full report in Codecov by Sentry. |
mtrezza
changed the title
|
@mtrezza thanks for fixing the CI, is this good? |
mtrezza
approved these changes
Jul 16, 2023
parseplatformorg
pushed a commit
that referenced
this pull request
Jul 16, 2023
# [5.2.0](5.1.3...5.2.0) (2023-07-16) ### Features * Add support for Live Activity with ActivityKit push notifications ([#130](#130)) ([80717cd](80717cd))
|
🎉 This change has been released in version 5.2.0 |
alanwguo
reviewed
Jul 19, 2023
|
|
||
| set event(value) { | ||
| if (typeof value === 'string' || value === undefined) { | ||
| this.aps.event = value; |
There was a problem hiding this comment.
Is this supposed to be events? The docs here refers to the key as "events": https://developer.apple.com/documentation/activitykit/updating-and-ending-your-live-activity-with-activitykit-push-notifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.apple.com/documentation/activitykit/updating-and-ending-your-live-activity-with-activitykit-push-notifications
This PR also fixes the broken tests.