Merge pull request #41 from ParsePlatform/peterjs.explitDisabledCheckbox

Add not allowed styles to bulk checkbox.
parse-community · Mar 4, 2016 · cccac55 · cccac55
2 parents 1691ddd + 6e55cb4
commit cccac55
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/components/DataBrowserHeaderBar/DataBrowserHeaderBar.react.js b/components/DataBrowserHeaderBar/DataBrowserHeaderBar.react.js
@@ -17,8 +17,10 @@ export default class DataBrowserHeaderBar extends React.Component {
   render() {
     let { headers, onResize, selected, selectAll, onAddColumn, updateOrdering, readonly, handleDragDrop } = this.props;
     let elements = [
+      // Note: bulk checkbox is disabled as all rows are selected (not just visible ones due to current lazy loading implementation)
+      // TODO: add bulk checking only visible rows
       <div key='check' className={[styles.wrap, styles.check].join(' ')}>
-        {readonly ? null : <input type='checkbox' disabled={true} checked={false} onChange={(e) => selectAll(e.target.checked)} />}
+        {readonly ? null : <input className={styles.disabled} type='checkbox' disabled={true} checked={false} onChange={(e) => selectAll(e.target.checked)} />}
       </div>
     ];
 

diff --git a/components/DataBrowserHeaderBar/DataBrowserHeaderBar.scss b/components/DataBrowserHeaderBar/DataBrowserHeaderBar.scss
@@ -64,3 +64,7 @@
   margin: 0 -4px;
   cursor: ew-resize;
 }
+
+.disabled {
+  cursor: not-allowed;
+}