Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on codemirror-graphql branch #1633

Closed
3 tasks done
mtrezza opened this issue Dec 22, 2020 · 21 comments
Closed
3 tasks done

Dependency on codemirror-graphql branch #1633

mtrezza opened this issue Dec 22, 2020 · 21 comments
Labels
type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@mtrezza
Copy link
Member

mtrezza commented Dec 22, 2020

Make sure these boxes are checked before submitting your issue -- thanks for reporting issues back to Parse Dashboard!

  • You're running version >=1.0.23 of Parse Dashboard.
  • You're running version >=2.3.2 of Parse Server.
  • You've searched through existing issues. Chances are that your issue has been reported or resolved before.

Environment Setup

Parse Dashboard has a dependency on a personal branch:

"codemirror-graphql": "github:timsuchanek/codemirror-graphql#details-fix",

The branch is not maintained.

Solution

The dependency should point to the original repository or Parse should to maintain its own fork if necessary.

@Nes-si
Copy link

Nes-si commented Jan 6, 2021

Seems like this issue makes it impossible using parse-dashboard in project if you have new npm version.
npm i finishes with an error:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! Found: graphql@15.4.0
npm ERR! node_modules/graphql
npm ERR!   graphql@"15.4.0" from parse-server@4.5.0
npm ERR!   node_modules/parse-server
npm ERR!     parse-server@"^4.5.0" from the root project
npm ERR!   peer graphql@"^14.0.0 || ^15.0.0" from graphql-language-service-parser@1.8.0
npm ERR!   node_modules/graphql-language-service-parser
npm ERR!     graphql-language-service-parser@"^1.0.18" from codemirror-graphql@0.6.12
npm ERR!     node_modules/codemirror-graphql
npm ERR!       codemirror-graphql@"github:timsuchanek/codemirror-graphql#details-fix" from parse-dashboard@2.1.0
npm ERR!       node_modules/parse-dashboard
npm ERR!         parse-dashboard@"^2.1.0" from the root project
npm ERR!     graphql-language-service-parser@"^1.2.2" from graphql-language-service-interface@1.3.2
npm ERR!     node_modules/codemirror-graphql/node_modules/graphql-language-service-interface
npm ERR!       graphql-language-service-interface@"^1.0.18" from codemirror-graphql@0.6.12
npm ERR!       node_modules/codemirror-graphql
npm ERR!         codemirror-graphql@"github:timsuchanek/codemirror-graphql#details-fix" from parse-dashboard@2.1.0
npm ERR!         node_modules/parse-dashboard
npm ERR!   4 more (graphql-language-service-types, apollo-link, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer graphql@"^0.10.0 || ^0.11.0 || ^0.12.0 || ^0.13.0" from graphql-language-service-interface@1.3.2
npm ERR! node_modules/codemirror-graphql/node_modules/graphql-language-service-interface
npm ERR!   graphql-language-service-interface@"^1.0.18" from codemirror-graphql@0.6.12
npm ERR!   node_modules/codemirror-graphql
npm ERR!     codemirror-graphql@"github:timsuchanek/codemirror-graphql#details-fix" from parse-dashboard@2.1.0
npm ERR!     node_modules/parse-dashboard
npm ERR!       parse-dashboard@"^2.1.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@ghost
Copy link

ghost commented Jan 25, 2021

I solved by deleting the node_modules folder and package-lock.json file and finally run npm i.

@Nes-si
Copy link

Nes-si commented Jan 25, 2021

I solved by deleting the node_modules folder and package-lock.json file and finally run npm i.

It's not a solution. The problem deals with new npm version (v7) which installs peer-dependencies. You obviously used npm v6 or earlier.

@moneppo
Copy link

moneppo commented Feb 13, 2021

Originally I got stuck believing that --legacy-peer-deps would work until this package was upgraded. I was able to downgrade to npm@16.14.11 to work around this issue.

@ritterb82
Copy link

Same problem. Can't run parse dashboard with latest npm version.

@ritterb82
Copy link

Originally I got stuck believing that --legacy-peer-deps would work until this package was upgraded. I was able to downgrade to npm@16.14.11 to work around this issue.

Just wanted to point out the version should be 6.14.11. ( not 16.14.11 )

@tomek-he-him
Copy link

tomek-he-him commented Feb 22, 2021

Just chipping in to let the maintainers know that this makes for a pretty disappointing first impression when getting started with Parse Server and the stable version of Node.js and npm 😬

@mtrezza
Copy link
Member Author

mtrezza commented Feb 22, 2021

Thanks everyone for pinning this down. I think we should add a compatibility table just like we have for Parse Server and ideally add CI tests to detect such incompatibilities.

Would anyone want to give it a try?

@mtrezza
Copy link
Member Author

mtrezza commented Mar 2, 2021

For convenience, this is how to downgrade from npm 7 to 6 on macOS using brew:

$ brew install node@14
$ brew unlink node
$ brew link --overwrite --force node@14

@stage88
Copy link

stage88 commented Mar 3, 2021

Would it work if we upgrade dependancy graphql-playground-react. It seems to be the one which breaks the install. See my comment here parse-community/parse-server#7090 (comment)

I dont have much experience with graphql, but I can try tomorrow. Its getting late here in AUS.

@mtrezza
Copy link
Member Author

mtrezza commented Mar 3, 2021

Thanks for trying this out. If we can't find a solution, we may have to either fork and maintain our own to bypass the prepare script or remove the codemirror / playground all together. The original package I referenced in this issue has been deprecated and moved into a mono-repo, but I also couldn't get to install that mono-repo.

@elijahjcobb
Copy link

Can confirm this is still an issue with the latest versions of everything.

@rakuemoevi
Copy link

rakuemoevi commented Apr 5, 2021

I can confirm i'm not able to deploy to heroku getting error message:
/usr/bin/git ls-remote -h -t ssh://git@github.com/timsuchanek/codemirror-graphql.git
remote: npm ERR!
remote: npm ERR! Host key verification failed.
remote: npm ERR! fatal: Could not read from remote repository.
I'm using:
"node": "13.14.0" and "npm": "6.14.4"

@tomek-he-him
Copy link

Node 14 and lower is not compatible with Apple Silicon chips (see nodejs/node#36161). It’s a deadlock – Parse Dashboard cannot be used on late 2020 Macs and newer 😱

@mtrezza
Copy link
Member Author

mtrezza commented Apr 17, 2021

I would think the dashboard runs on Node 15 too, have you tried? Is this related to this issue or something separate?

@tomek-he-him
Copy link

Node 15 ships with npm 7, which refuses to install parse-dashboard.

If you’re suggesting we can downgrade npm to v6 on Node 15, I didn’t try that, because it’s a very painful workflow that I wouldn’t want to introduce. Everyone on the team would need to remember to switch to a non-default version of npm after installing Node.

@stale
Copy link

stale bot commented Jun 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 26, 2021
@danielsanfr
Copy link

Don't close it please.

@stale stale bot removed the stale label Jun 26, 2021
@mtrezza
Copy link
Member Author

mtrezza commented Jun 26, 2021

Node 14 and lower is not compatible with Apple Silicon chips (see nodejs/node#36161). It’s a deadlock – Parse Dashboard cannot be used on late 2020 Macs and newer 😱

Isn't that also true for Parse Server? I think it currently also doesn't install with npm 7 due to dependency issues.

Can anyone try and confirm this?

@alljinx
Copy link

alljinx commented Jun 26, 2021

Node 14 and lower is not compatible with Apple Silicon chips (see nodejs/node#36161). It’s a deadlock – Parse Dashboard cannot be used on late 2020 Macs and newer 😱

Isn't that also true for Parse Server? I think it currently also doesn't install with npm 7 due to dependency issues.

Can anyone try and confirm this?

No problem installing Parse Server with npm 7 but no way for Parse Dashboard even with the lagacy peer deps or the force option. With regret, we are forced to consider discontinuing the use of this package. It's sad, especially just for one dependency...

@mtrezza mtrezza added the type:bug Impaired feature or lacking behavior that is likely assumed label Aug 19, 2021
@dblythy
Copy link
Member

dblythy commented Sep 29, 2021

Closed via #1807

@dblythy dblythy closed this as completed Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
Development

No branches or pull requests