Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitting backspace key in data browser crashes dashboard #2453

Closed
4 tasks done
mtrezza opened this issue Jun 9, 2023 · 5 comments · Fixed by #2456
Closed
4 tasks done

Hitting backspace key in data browser crashes dashboard #2453

mtrezza opened this issue Jun 9, 2023 · 5 comments · Fixed by #2456
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@mtrezza
Copy link
Member

mtrezza commented Jun 9, 2023

New Issue Checklist

Issue Description

Hitting backspace key in data browser crashes dashboard

with error:

[Error] TypeError: undefined is not an object (evaluating 'this.props.value._previousSave')
value — dashboard.bundle.js:104940:115

at line:

if (this.props.value !== e.value && (this.renderCellContent(), null === (t = this.props.value._previousSave) || void 0 === t || null === (n = t.then((function() {

Bug introduced by #2422.

Steps to reproduce

  1. Open data browser
  2. Select deletable field
  3. Hit backspace key

Actual Outcome

Error thrown, window goes blank.

Expected Outcome

Delete field value.

Environment

Dashboard

  • Parse Dashboard version: 5.2.0-alpha.11
@parse-github-assistant
Copy link

parse-github-assistant bot commented Jun 9, 2023

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@mtrezza mtrezza added the type:bug Impaired feature or lacking behavior that is likely assumed label Jun 9, 2023
@mtrezza
Copy link
Member Author

mtrezza commented Jun 9, 2023

@patelmilanun Maybe you have time to take a quick look at this; the bug has been introduced by #2422, and maybe it's quickest for you to look at this since you worked on the code recently. Thanks!

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-alpha.14

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jun 10, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-beta.2

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 10, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants