Skip to content

fix(FileEditor): Error: Tried to encode an unsaved file #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(FileEditor): Error: Tried to encode an unsaved file #1224

wants to merge 1 commit into from

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Aug 15, 2019

No description provided.

@douglasmuraoka
Copy link
Contributor

I don't think this is the right approach to solve this bug. We'll lose the Uploading... component state, and also block the UI until the file upload is done.
From what I've investigated, it is more related to the obj.toJSON that I'm using to get the raw object and array data than the file upload itself. I'll try to find some alternatives to resolve this.

@dplewis
Copy link
Member Author

dplewis commented Aug 15, 2019

Thanks for looking into this. I’ll also try to find an alternative.

@dplewis
Copy link
Member Author

dplewis commented Aug 15, 2019

Closing via #1225

@dplewis dplewis closed this Aug 15, 2019
@dplewis dplewis deleted the fix-file-editor branch August 23, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davimacedo davimacedo Awaiting requested review from davimacedo

@douglasmuraoka douglasmuraoka Awaiting requested review from douglasmuraoka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dplewis @douglasmuraoka