Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Database Browser): Table not scrolling when using arrow keys #1239

Merged
merged 3 commits into from
Aug 22, 2019
Merged

fix(Database Browser): Table not scrolling when using arrow keys #1239

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a66bb82
fix(Database Browser): Table not scrolling when using arrow keys
douglasmuraoka Aug 22, 2019
e56e120
Merge branch 'master' into fix_browser_table_not_autoscrolling
douglasmuraoka Aug 22, 2019
f2e0caa
Merge branch 'master' into fix_browser_table_not_autoscrolling
davimacedo Aug 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion src/components/BrowserCell/BrowserCell.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,32 @@ import { dateStringUTC } from 'lib/DateUtils';
import getFileName from 'lib/getFileName';
import Parse from 'parse';
import Pill from 'components/Pill/Pill.react';
import React from 'react';
import React, { useEffect, useRef }
from 'react';
import styles from 'components/BrowserCell/BrowserCell.scss';
import { unselectable } from 'stylesheets/base.scss';

let BrowserCell = ({ type, value, hidden, width, current, onSelect, onEditChange, setRelation, onPointerClick }) => {
const cellRef = current ? useRef() : null;
if (current) {
useEffect(() => {
const node = cellRef.current;
const { left, right, bottom, top } = node.getBoundingClientRect();

// Takes into consideration Sidebar width when over 980px wide.
const leftBoundary = window.innerWidth > 980 ? 300 : 0;

// BrowserToolbar + DataBrowserHeader height
const topBoundary = 126;

if (left < leftBoundary || right > window.innerWidth) {
node.scrollIntoView({ behavior: 'smooth', block: 'nearest', inline: 'start' });
} else if (top < topBoundary || bottom > window.innerHeight) {
node.scrollIntoView({ behavior: 'smooth', block: 'nearest', inline: 'nearest' });
}
});
}

let content = value;
let classes = [styles.cell, unselectable];
if (hidden) {
Expand Down Expand Up @@ -98,6 +119,7 @@ let BrowserCell = ({ type, value, hidden, width, current, onSelect, onEditChange
}
return (
<span
ref={cellRef}
className={classes.join(' ')}
style={{ width }}
onClick={onSelect}
Expand Down