Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Database Browser): Table performance improvements #1241

Merged

Conversation

douglasmuraoka
Copy link
Contributor

Improves the general performance of the Browsercomponent and its nested components, in order to provide a smoother experience.

  • Improved table scrolling UX by increasing the number of elements rendered on screen (from 60 to 200) and increasing the number of rows needed to trigger a rerender of the entire table (from 20 to 160). Now users can scroll way more without stuttering (needs more testing on older devices).
  • Removed several unnecessary renderings during initialization. Browsercomponent initialization has become faster.
  • Removed several unnecessary table row and cell renderings whenever a table cell is selected, causing stuttering when holding an arrow key for navigation (instead of updating only the old/new selected cell, it was updating the entire table).

@dplewis
Copy link
Member

dplewis commented Aug 24, 2019

I noticed that sometimes I can’t scroll pass two-three pages if I go really fast. That includes using arrow keys

@douglasmuraoka
Copy link
Contributor Author

@dplewis could you please take a look again?

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me! LGTM!

@davimacedo davimacedo merged commit 859a011 into parse-community:master Aug 29, 2019
beiguancyc pushed a commit to beiguancyc/parse-dashboard that referenced this pull request Sep 10, 2019
* commit '54ce71875033d8c3309d4f18090ac8336795d4de': (54 commits)
  2.0.1 (parse-community#1264)
  2.0.0 (parse-community#1263)
  Update cross-env to the latest version 🚀 (parse-community#1262)
  Update query-string to the latest version 🚀 (parse-community#1261)
  Update path-to-regexp to the latest version 🚀 (parse-community#1260)
  Update sass-loader to the latest version 🚀 (parse-community#1254)
  fix(Database Browser): Cell edit not updating partial view (parse-community#1255)
  Update eslint to the latest version 🚀 (parse-community#1259)
  Update commander to the latest version 🚀 (parse-community#1257)
  Update eslint-plugin-jest to the latest version 🚀 (parse-community#1256)
  Update graphql to the latest version 🚀 (parse-community#1253)
  refactor(Database Browser): Table performance improvements (parse-community#1241)
  Update parse to the latest version 🚀 (parse-community#1252)
  Update webpack to the latest version 🚀 (parse-community#1251)
  build(deps): bump eslint-utils from 1.4.0 to 1.4.2 (parse-community#1249)
  Update babel-eslint to the latest version 🚀 (parse-community#1245)
  fix: Avoid filter tab disappears on apply filter (parse-community#1229)
  Update graphql to the latest version 🚀 (parse-community#1243)
  Update graphql to the latest version 🚀 (parse-community#1242)
  Update graphql to the latest version 🚀 (parse-community#1240)
  ...

# Conflicts:
#	package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants