Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Sidebar collapse #1269

Closed

Conversation

douglasmuraoka
Copy link
Contributor

@douglasmuraoka douglasmuraoka commented Sep 6, 2019

Removes the old SidebarToggle component and allows users to collapse the sidebar even when window width is greater than 980px. Adds a Pin button that fixes the sidebar, avoiding any collapses.
Once collapsed, expands the sidebar when on mouse over, and collapses on mouse leave.

Collapsed:
image

Expanded:
image

Closes #1759.

@davimacedo
Copy link
Member

@douglasmuraoka thanks for working on this. Few questions:

  • The arrow in the App Select stopped changing when the Select is opened/closed. Is it also possible to change its color to white?
  • Is it possible to change the pin button color to white?
  • Is it possible to have the pin button changed so the user can know if it is pinned or not?

@stale
Copy link

stale bot commented Dec 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the state:wont-fix Won’t be fixed with a clearly stated reason label Dec 7, 2019
@stale stale bot closed this Dec 14, 2019
@tehsunnliu
Copy link

Hi all, I've noticed this issue has not been merged. I was facing issues when using the parse-dashboard on a smaller screen.
The sidebar doesn't collapse and the table goes behind the sidebar hiding the columns behind it. I'm using parse release version 2.1.0.
dashboard-1
dashboard

Is there any chance of getting this fixed?
Thank you.

@TomWFox TomWFox reopened this Oct 21, 2020
@ghost
Copy link

ghost commented Oct 21, 2020

Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page.

Generated by 🚫 dangerJS

@TomWFox TomWFox removed the state:wont-fix Won’t be fixed with a clearly stated reason label Oct 21, 2020
@tehsunnliu
Copy link

Please merge this. The dashboard sidebar needs a Fix.
Or guide me to fix the Danger.

@mtrezza
Copy link
Member

mtrezza commented Aug 18, 2021

@tehsunnliu Thanks for bringing this to our attention. I think it just needs a rebase on master, then we can merge it. I'll look into that.

@mtrezza mtrezza mentioned this pull request Aug 18, 2021
3 tasks
@mtrezza
Copy link
Member

mtrezza commented Aug 18, 2021

There are some fixed necessary, continued in #1760

@mtrezza mtrezza closed this Aug 18, 2021
@tehsunnliu
Copy link

Hi @mtrezza Thank you so much for initiating this. I'll check this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(sidebar): collapse sidebar
6 participants