Skip to content

Fixes EditRowDialog #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2020
Merged

Fixes EditRowDialog #1586

merged 1 commit into from
Oct 29, 2020

Conversation

NinoZX
Copy link
Contributor

@NinoZX NinoZX commented Sep 1, 2020

  • update fields automatically when they are updated on server
  • don't update array, object and polygon when no changes are in the field
  • GeoPointEditor component added componentWillReceiveProps for values change
  • TextInput component textarea mode added rows props to be used

@NinoZX
Fixes:
740c5ab 
- update fields automatically when they are updated on server
- don't update array, object and polygon when no changes are in the field
- GeoPointEditor added componentWillReceiveProps on values change
- TextInput textarea added rows props to be used
@NinoZX
Copy link
Contributor Author

NinoZX commented Sep 1, 2020

@mtrezza here is the new PR request at this point

dplewis
dplewis approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it out and works perfectly. Thanks for the PR.

@dplewis dplewis merged commit 5b03d39 into parse-community:master Oct 29, 2020
@ghost
Copy link

ghost commented Oct 29, 2020

Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page.

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dplewis dplewis dplewis approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NinoZX @dplewis