-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pointer representation by a chosen column instead of objectId #1723
Conversation
I will revert the package-lock.json but I'd need to add sweet alert dependency. |
Thanks for this PR. Can you please rename the PR title accordingly? |
I have updated the PR title. |
Thank you.
|
|
Can we make this more efficient and do a single query for all objects in sync with the paging mechanism?
Yes, it would be good if you could use the components we have. Every dependency is a cost factor for maintenance, security, etc. so we want to avoid adding new ones if they are not necessary. |
I've pushed a commit that will optimize the query. The second query has been removed and instead I've added include and select on the first query that fetches the data. I'll update the dialog in the upcoming commits. |
Great, kindly let me know when this is ready for review. |
I've cleaned up the code and the PR is ready to be reviewed. |
@mtrezza For the first issue regarding the pointers, I tried the steps above in the following video but could not reproduce the issue. Screen.Recording.2021-09-29.at.9.31.49.PM.mov |
Thanks, I'll take another look. Maybe you can take a look this meanwhile. |
To make sure it doesn't get overlooked, the issue review is on hold because of #1723 (comment) |
@mtrezza I've reverted the changes for comment #1723 (comment) |
Great, did you look through the whole PR if there are any other modifications that are not part of this PR? |
@mtrezza I went through the PR and it only seems to have changes related to pointer key issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Amazing feature and great work 👏
🎉 This pull request has been released in version 3.3.0-alpha.2 |
Issue 151 link
If no key is specified, the pointer value falls back to objectId.
Caveat
There's no caching mechanism for pointer so if the same pointer value ( class objectID ) is used in multiple rows, it'll query DB for each of the new row.