-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: manual column preferences are overwritten by columnPreference
option on page refresh
#1881
fix: manual column preferences are overwritten by columnPreference
option on page refresh
#1881
Conversation
Thanks for opening this pull request!
|
@vince1995 Could you please open an issue with more information to discuss this, and reference it here? |
33c1015
to
6bcf13f
Compare
fixes #1882 |
columnPreferences
is usedcolumnPreference
option is used
columnPreference
option is usedcolumnPreference
option
columnPreference
optioncolumnPreference
option on page refresh
columnPreference
option on page refreshcolumnPreference
option on page refresh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Makes sense to overwrite the config with the manually set column prefs.
# [3.3.0-alpha.12](3.3.0-alpha.11...3.3.0-alpha.12) (2021-10-27) ### Bug Fixes * manual column preferences are overwritten by columnPreference option on page refresh ([#1881](#1881)) ([7232b0b](7232b0b))
🎉 This pull request has been released in version 3.3.0-alpha.12 |
# [3.3.0-beta.1](3.2.1-beta.1...3.3.0-beta.1) (2021-11-01) ### Bug Fixes * always pass boolean value when toggling checkbox ([#1872](#1872)) ([2e9fd59](2e9fd59)) * app icons are cropped in the app list for small screen sizes ([#1876](#1876)) ([9fc56a6](9fc56a6)) * link icon in pointer cell not visible when cell is too narrow ([#1856](#1856)) ([69b897d](69b897d)) * manual column preferences are overwritten by columnPreference option on page refresh ([#1881](#1881)) ([7232b0b](7232b0b)) * notification to upgrade dashboard for latest features not working ([#1894](#1894)) ([81361b6](81361b6)) * upgrade graphql from 15.4.0 to 15.6.0 ([#1853](#1853)) ([fca9b14](fca9b14)) * upgrade graphql from 15.6.0 to 15.6.1 ([#1887](#1887)) ([0cfe59e](0cfe59e)) * upgrade inquirer from 8.1.3 to 8.2.0 ([#1886](#1886)) ([c77f335](c77f335)) * upgrade passport from 0.4.1 to 0.5.0 ([#1865](#1865)) ([8d845f0](8d845f0)) * upload of file as default value fails when adding a new column ([#1875](#1875)) ([6040dd0](6040dd0)) ### Features * add config option `columnPreference.filterSortToTop` to set column name order in filter dialog ([#1884](#1884)) ([3acbda1](3acbda1)) * add pointer representation by a chosen column instead of objectId ([#1852](#1852)) ([d747786](d747786)) * add visual distinction in data browser for internal classes and display their real names with underscore ([#1878](#1878)) ([ac8d85e](ac8d85e)) * allow GraphIQL headers ([#1836](#1836)) ([3afcf73](3afcf73)) * allow graphQL headers ([34536b3](34536b3)) ### Reverts * Revert "Update CloudCode.react.js" ([eea1e2d](eea1e2d))
🎉 This change has been released in version 3.3.0-beta.1 |
# [3.3.0](3.2.1...3.3.0) (2022-01-01) ### Bug Fixes * always pass boolean value when toggling checkbox ([#1872](#1872)) ([2e9fd59](2e9fd59)) * app icons are cropped in the app list for small screen sizes ([#1876](#1876)) ([9fc56a6](9fc56a6)) * bump graphiql from 1.4.6 to 1.4.7 ([#1920](#1920)) ([35fd021](35fd021)) * context menu in data browser not opening for cell of type number ([#1913](#1913)) ([8731c35](8731c35)) * link icon in pointer cell not visible when cell is too narrow ([#1856](#1856)) ([69b897d](69b897d)) * manual column preferences are overwritten by columnPreference option on page refresh ([#1881](#1881)) ([7232b0b](7232b0b)) * notification to upgrade dashboard for latest features not working ([#1894](#1894)) ([81361b6](81361b6)) * upgrade graphql from 15.4.0 to 15.6.0 ([#1853](#1853)) ([fca9b14](fca9b14)) * upgrade graphql from 15.6.0 to 15.6.1 ([#1887](#1887)) ([0cfe59e](0cfe59e)) * upgrade inquirer from 8.1.3 to 8.2.0 ([#1886](#1886)) ([c77f335](c77f335)) * upgrade passport from 0.4.1 to 0.5.0 ([#1865](#1865)) ([8d845f0](8d845f0)) * upload of file as default value fails when adding a new column ([#1875](#1875)) ([6040dd0](6040dd0)) ### Features * add config option `columnPreference.filterSortToTop` to set column name order in filter dialog ([#1884](#1884)) ([3acbda1](3acbda1)) * add pointer representation by a chosen column instead of objectId ([#1852](#1852)) ([d747786](d747786)) * add visual distinction in data browser for internal classes and display their real names with underscore ([#1878](#1878)) ([ac8d85e](ac8d85e)) * allow GraphIQL headers ([#1836](#1836)) ([3afcf73](3afcf73)) * allow graphQL headers ([34536b3](34536b3)) ### Reverts * Revert "Update CloudCode.react.js" ([eea1e2d](eea1e2d))
🎉 This change has been released in version 3.3.0 |
New Pull Request Checklist
Approach
It feels like a bug that the
columnPreference
from the settings are not overwritten by the user settings from the UI. This PR solves this.TODOs before merging