Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change example config Parse Server port from 1338 to 1337 #2012

Merged
merged 1 commit into from
Jan 23, 2022

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Jan 23, 2022

New Pull Request Checklist

Issue Description

Change the Parse Server port in the dashboard example config file from 1338 to 1337. This is also the default port of Parse Server, so it makes sense for Parse Dashboard to also talk to that port by default. This should is not considered a breaking change as the config file is merely an example config file that also includes other "example values" like helloand world as username and password.

Related issue: #2013

Approach

Change port 1338 to 1337.

TODOs before merging

  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jan 23, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mtrezza mtrezza linked an issue Jan 23, 2022 that may be closed by this pull request
4 tasks
@mtrezza mtrezza changed the title fix: change example config Parse Server port from 1338 to 1337 refactor: change example config Parse Server port from 1338 to 1337 Jan 23, 2022
@mtrezza mtrezza merged commit 4ffd6fc into parse-community:alpha Jan 23, 2022
@mtrezza mtrezza deleted the change-example-config-port branch January 23, 2022 01:02
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0-alpha.13

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jan 23, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0-beta.3

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Feb 6, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.1

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 3, 2022
beiguancyc pushed a commit to beiguancyc/parse-dashboard that referenced this pull request Mar 4, 2022
* source: (43 commits)
  chore(release): 4.0.1 [skip ci]
  ci: release commit
  chore(release): 4.0.0-beta.3 [skip ci]
  ci: release commit
  refactor: upgrade prismjs from 1.25.0 to 1.26.0 (parse-community#2019)
  chore(release): 4.0.0-alpha.15 [skip ci]
  fix: preserve column sorting preferences in data browser (parse-community#2016)
  refactor: upgrade prop-types from 15.8.0 to 15.8.1 (parse-community#2018)
  refactor: upgrade otpauth from 7.0.8 to 7.0.9 (parse-community#2017)
  chore(release): 4.0.0-alpha.14 [skip ci]
  fix: crash when checking for new dashboard release without internet connection (parse-community#2015)
  chore(release): 4.0.0-alpha.13 [skip ci]
  fix: calendar widget layout partly hides last days of a month (parse-community#1990)
  refactor: change example config Parse Server port from 1338 to 1337 (parse-community#2012)
  chore(release): 4.0.0-alpha.12 [skip ci]
  fix: upgrade parse from 3.4.0 to 3.4.1 (parse-community#2011)
  chore(release): 4.0.0-alpha.11 [skip ci]
  fix: various UI bugs (e.g. filter data browser, switch app, upload file) (parse-community#2010)
  chore(release): 4.0.0-alpha.10 [skip ci]
  fix: bump nanoid from 3.1.28 to 3.2.0 (parse-community#2008)
  ...

# Conflicts:
#	package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example config expects Parse Server on port 1338 instead of 1337
2 participants