-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: remove support links #2185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request!
|
Hi Guys (@mtrezza, @Moumouls, @dblythy, @cbaker6, @davimacedo, @dplewis) I think I am going to give up on this. |
@MrMartinR I don't think the passport dep has anything to do with this PR, simply removing the links like what you've done in this PR should be enough. I suggest you check your local node version, and if you cannot get dashboard to run locally, you could ask for help in chat. Also:
|
Hi @parse-community/dashboard !, all the checks passed, can someone review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm not mistaken, I don't think there is a confirmation dialog before logging out. Maybe it's best for UX to keep the logout menu as a submenu, so it requires 2 clicks. That will also make it easier to add more menu options in the future.
And I'd remove that hand emoji. It's a style that isn't used anywhere else in the dashboard.
Yeah, I am not very happy with the emoji neither.. |
Yes, maybe keep the 3 dots and only leave the Logout without the hand emoji? There are some icons in the dashboard repo where you may find a log out icon, but you don't really need to dig into that, not even sure if there is one. |
There are no logout/exit icon, probably in the future I will come back to this and I will create a logout icon, I am not 100% happy with the css I had to tweak because is just 1 element in the popover, probably in the future when I am more familiar with the code I will improve that. |
Could you test out #2203 and see if it works? I've made a few changes to make the button larger when used with a touch UI and changes the menu text. I actually opened the PR because this PR did not display the pop-up correctly when I was testing it out, so I thought you needed some help, but it tuns out that your button works fine. So you can either incorporate the changes in this PR and I'll close the other one, or you can close this one and I'll merge the other one, whatever you prefer. If you want to use this PR, please look for unnecessary changes like added empty lines or spaces, these should be removed. |
Fix for #2184