Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve button labels to be more concise in text #2207

Merged
merged 7 commits into from
Jul 11, 2022

Conversation

MrMartinR
Copy link
Contributor

@MrMartinR MrMartinR commented Jul 4, 2022

New Pull Request Checklist

Issue Description

Rename cancel button from Nevermind, Don't, to Cancel
Rename confirmation button from Yes <action> to Yes

Related issue: #2186

Approach

n/a

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jul 4, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@MrMartinR
Copy link
Contributor Author

Hi @parse-community/dashboard, can you review this PR?

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a similar issue with the "Yes"-like buttons, do you want to change them in one go with this PR?

For example "Do you want to clone?" - "Yes clone" is unnecessary, just "Yes" is enough.

You could just adapt the PR description and title. If you want to make these changes as well of course.

@MrMartinR MrMartinR changed the title feat: rename button nevermind to Cancel feat: rename labels buttons nevermind to Cancel and Yes <action> to Yes Jul 7, 2022
@MrMartinR MrMartinR requested a review from mtrezza July 7, 2022 12:16
@mtrezza mtrezza changed the title feat: rename labels buttons nevermind to Cancel and Yes <action> to Yes feat: improve button labels to be more concise in text Jul 7, 2022
@MrMartinR MrMartinR requested a review from mtrezza July 8, 2022 10:55
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just a small change

src/dashboard/Data/Browser/CreateClassDialog.react.js Outdated Show resolved Hide resolved
@MrMartinR MrMartinR requested a review from mtrezza July 10, 2022 10:53
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MrMartinR MrMartinR requested review from mtrezza and a team and removed request for mtrezza July 11, 2022 10:46
@mtrezza mtrezza merged commit 230fc14 into parse-community:alpha Jul 11, 2022
@mtrezza mtrezza removed the request for review from a team July 11, 2022 10:54
@MrMartinR MrMartinR deleted the rename-nevermind branch July 11, 2022 10:55
parseplatformorg pushed a commit that referenced this pull request Jul 11, 2022
# [4.2.0-alpha.2](4.2.0-alpha.1...4.2.0-alpha.2) (2022-07-11)

### Features

* improve button labels to be more concise in text ([#2207](#2207)) ([230fc14](230fc14))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.2.0-alpha.2

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jul 11, 2022
parseplatformorg pushed a commit that referenced this pull request Sep 2, 2022
# [4.2.0-beta.1](4.1.3...4.2.0-beta.1) (2022-09-02)

### Bug Fixes

* button text "Show all" in column menu is truncated ([#2208](#2208)) ([b89d044](b89d044))
* login fails with error `req.session.regenerate is not a function` ([#2195](#2195)) [skip release] ([31a2b78](31a2b78))
* login fails with error `req.session.regenerate is not a function` ([#2197](#2197)) [skip release] ([014d9c1](014d9c1))
* security upgrade terser from 5.10.0 to 5.14.2 ([#2222](#2222)) ([645cfdd](645cfdd))

### Features

* improve button labels to be more concise in text ([#2207](#2207)) ([230fc14](230fc14))
* remove support and documentation links ([#2203](#2203)) ([35e4476](35e4476))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.2.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Sep 2, 2022
parseplatformorg pushed a commit that referenced this pull request Oct 15, 2022
# [4.2.0](4.1.4...4.2.0) (2022-10-15)

### Bug Fixes

* button text "Show all" in column menu is truncated ([#2208](#2208)) ([b89d044](b89d044))
* column names in data browser menu not left-aligned ([#2263](#2263)) ([fc5673a](fc5673a))
* context menu in data browser is not scrollable ([#2271](#2271)) ([6c54bd8](6c54bd8))
* dashboard contains invalid html for top-level document ([#2254](#2254)) ([bbce857](bbce857))
* file upload dialog in data browser shows multiple times ([#2276](#2276)) ([3927340](3927340))
* login fails with error `req.session.regenerate is not a function` ([#2195](#2195)) [skip release] ([31a2b78](31a2b78))
* login fails with error `req.session.regenerate is not a function` ([#2197](#2197)) [skip release] ([014d9c1](014d9c1))
* login fails with error `req.session.regenerate is not a function` ([#2260](#2260)) ([1dc2b91](1dc2b91))
* security upgrade terser from 5.10.0 to 5.14.2 ([#2222](#2222)) ([645cfdd](645cfdd))
* unnecessary count operations in Data Browser ([#2250](#2250)) ([bfc1684](bfc1684))
* view relation dialog requires browser refresh when navigating ([#2275](#2275)) ([d60a8b7](d60a8b7))

### Features

* add column name to related records ([#2264](#2264)) ([cc82533](cc82533))
* add Node 18 support ([#2206](#2206)) ([bc7895a](bc7895a))
* add option to auto-sort columns alphabetically ([#2252](#2252)) ([2b7f20f](2b7f20f))
* apply filter in data browser by pressing "Enter" key ([#2256](#2256)) ([bc4f9eb](bc4f9eb))
* auto-submit one-time password (OTP) after entering ([#2257](#2257)) ([e528705](e528705))
* improve button labels to be more concise in text ([#2207](#2207)) ([230fc14](230fc14))
* remove support and documentation links ([#2203](#2203)) ([35e4476](35e4476))
* show skeleton as loading indicator in data browser while data is loading ([#2273](#2273)) ([059f616](059f616))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants