-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR Preview Environments for Parse Dashboard — Uffizzi Integration #2352
Conversation
Thanks for opening this pull request!
|
hey, @mtrezza , this is the PoC or Parse dashboard + Uffizzi integration. Thank you for helping us understand Parse's ecosystem better! Let me know if this looks good~ |
Very nice! This should save reviewers some time as they can just verify the changes directly from the PR.
|
Hi @mtrezza, I can answer those questions for you. -Yes you would be on the "Open Source" plan -Uffizzi is not designed to replace your local IDE but it's certainly possible that contributors could use it in that way. I can think of 2 ways to address it -
We're happy to support whichever workflow is best for your project - either GHA or as a plug-in. Most Open Source projects use GHA but some utilize the plug-in model. Here's an example of an open source project that uses Uffizzi as a plug-in. Other notes- -If you'd like the plug-in model we would close this PR and open a PR with only docker-compose.uffizzi.yml. Once the docker-compose.uffizzi.yml is merged, you would create a Uffizzi Team account through our UI and "connect" to the docker-compose.uffizzi.yml to complete account set-up. This is a pretty simple process but does require a little more set-up work on your end. We'd be happy to jump on a zoom call and talk through any of this if that would be helpful. |
Hi, @mtrezza, hope you were able to go over Josh's comment, and that your concerns re scalability were answered. |
hey @mtrezza, do let me know what your thoughts are on this, and/or if this needs any modifications, feel free to share those, too. I hope this fits into the project's timeline. |
@parse-community/dashboard your feedback is welcome, seem to be an interesting addition to easily demo the PR @ShrutiC-git is there any way to simplify / reduce the changes needed for the integration? this PR create quite some configuration overhead in the repo for a single integration |
@mtrezza, I do see your concern.
Additional files depend upon the project. In this project, we also have the config from Nginx, which acts as a proxy for traffic into our containers. What I can do is keep the Nginx configuration to one file, rather than two, which would reduce to a total of 4 files. There is the other option that @jpthurman pointed out, which is using our platform to provision previews. In this case, we would not need the GHA workflow files ( |
The option using the platform to provision previews sounds good to reduce the config overhead. Any cons? |
There are no cons. It's just the preference of the project. Moving to our platform would reduce the overhead of GHA workflow. Should we switch to building on our platform? |
Yes, I think it makes sense to use your UI if that reduces the code. |
Superseded by #2364 |
New Pull Request Checklist
Issue Description
This PR extends parse-dashboard's GHA workflows and utilizes parse-dashboard's dockerfile to build a docker-compose, which is then used to spin up containers containing the services we are testing parse-dashboard with. This PR uses Postgres, parse-dashboard, and parse-server.
Parse-dashboard image is built from the source, which allows changes to reflect in the preview environment. The services are put behind a proxy for internal routing. No change has been made in the source code itself.
When a PR event is triggered on parse-dashboard (PR opened, synced, etc), Uffizzi workflows will be triggered and either deploy a new Uffizzi Preview or update an existing one. Once the preview is deployed, a comment will be posted on the PR containing the URL of the preview environment, allowing easy navigation.
Here is a PoC for Parse-dashboard preview on Uffizzi - a PR opened against the main in my fork of Parse-dashboard. Here is the comment on that PR.
This is the preview URL.
To log into the preview, use the following credentials:
Approach
TODOs before merging