Skip to content

feat: Allow row selection in data browser by dragging mouse outside of selection box column #2716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2025
+6 −1
Merged

feat: Allow row selection in data browser by dragging mouse outside of selection box column #2716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
892141a
feat: add row drag selection
dblythy Apr 6, 2025
fb5531a
Merge branch 'alpha' into feature/drag-selection
mtrezza Apr 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/BrowserRow/BrowserRow.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ export default class BrowserRow extends Component {
onMouseDownRowCheckBox,
onMouseUpRowCheckBox,
onMouseOverRowCheckBox,
onMouseOverRow,
} = this.props;
const attributes = obj.attributes;
let requiredCols = [];
Expand All @@ -69,7 +70,7 @@ export default class BrowserRow extends Component {
requiredCols = ['authData'];
}
return (
<div className={styles.tableRow} style={{ minWidth: rowWidth }}>
<div className={styles.tableRow} style={{ minWidth: rowWidth }} onMouseOver={() => onMouseOverRow(obj.id)}>
<span
className={styles.checkCell}
onMouseUp={onMouseUpRowCheckBox}
Expand Down
1 change: 1 addition & 0 deletions src/dashboard/Data/Browser/Browser.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2078,6 +2078,7 @@ class Browser extends DashboardView {
showNote={this.showNote}
onMouseDownRowCheckBox={this.onMouseDownRowCheckBox}
onMouseUpRowCheckBox={this.onMouseUpRowCheckBox}
onMouseOverRow={this.onMouseOverRowCheckBox}
onMouseOverRowCheckBox={this.onMouseOverRowCheckBox}
classes={this.classes}
classwiseCloudFunctions={this.state.classwiseCloudFunctions}
Expand Down
3 changes: 3 additions & 0 deletions src/dashboard/Data/Browser/BrowserTable.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ export default class BrowserTable extends React.Component {
onMouseDownRowCheckBox={this.props.onMouseDownRowCheckBox}
onMouseUpRowCheckBox={this.props.onMouseUpRowCheckBox}
onMouseOverRowCheckBox={this.props.onMouseOverRowCheckBox}
onMouseOverRow={this.props.onMouseOverRow}
setShowAggregatedData={this.props.setShowAggregatedData}
setErrorAggregatedData={this.props.setErrorAggregatedData}
firstSelectedCell={this.props.firstSelectedCell}
Expand Down Expand Up @@ -260,6 +261,7 @@ export default class BrowserTable extends React.Component {
onMouseDownRowCheckBox={this.props.onMouseDownRowCheckBox}
onMouseUpRowCheckBox={this.props.onMouseUpRowCheckBox}
onMouseOverRowCheckBox={this.props.onMouseOverRowCheckBox}
onMouseOverRow={this.props.onMouseOverRow}
setShowAggregatedData={this.props.setShowAggregatedData}
setErrorAggregatedData={this.props.setErrorAggregatedData}
firstSelectedCell={this.props.firstSelectedCell}
Expand Down Expand Up @@ -349,6 +351,7 @@ export default class BrowserTable extends React.Component {
onMouseDownRowCheckBox={this.props.onMouseDownRowCheckBox}
onMouseUpRowCheckBox={this.props.onMouseUpRowCheckBox}
onMouseOverRowCheckBox={this.props.onMouseOverRowCheckBox}
onMouseOverRow={this.props.onMouseOverRow}
setShowAggregatedData={this.props.setShowAggregatedData}
setErrorAggregatedData={this.props.setErrorAggregatedData}
firstSelectedCell={this.props.firstSelectedCell}
Expand Down
Loading