Skip to content

fix: Saving new filter in data browser overwrites filters added in other dashboard instances #2769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 2, 2025
Merged

fix: Saving new filter in data browser overwrites filters added in other dashboard instances #2769

merged 4 commits into from
May 2, 2025

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Apr 27, 2025 •
edited by coderabbitai bot
Loading

New Pull Request Checklist

Issue Description

Closes: #2711

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

Summary by CodeRabbit

  • Refactor
    • Improved preference management by removing in-memory caching. Preferences are now always read directly from local storage, ensuring the most up-to-date information is used. No changes to the way you interact with preferences.

@parse-github-assistant Parse GitHub Assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: remove filter cache fix: Remove filter cache Apr 27, 2025
@parse-github-assistant Parse GitHub Assistant
Copy link

parse-github-assistant bot commented Apr 27, 2025 •
edited
Loading

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

@parseplatformorg
Copy link
Contributor

parseplatformorg commented Apr 27, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

@uffizzi-cloud Uffizzi Cloud
Copy link

uffizzi-cloud bot commented Apr 27, 2025

Uffizzi Ephemeral Environment deployment-63188

⌚ Updated Apr 27, 2025, 08:10 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2769

📄 View Application Logs etc.

What is Uffizzi? Learn more

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 28, 2025 •
edited
Loading

Walkthrough

The update removes the in-memory caching mechanism for class preferences in the src/lib/ClassPreferences.js module. Now, all preference reads and writes interact directly with localStorage without using an intermediate cache. The functions for updating, retrieving, and getting all preferences retain their original signatures and error handling, but any logic related to the cache object has been deleted.

Changes

File(s) Change Summary
src/lib/ClassPreferences.js Removed in-memory caching of preferences; all reads/writes now go directly to localStorage.

Assessment against linked issues

Objective Addressed Explanation
Prevent saving a filter from overwriting unloaded filters in other dashboard instances (#2711) ❌ The change removes caching but does not implement merging or additive saving logic to prevent overwrites.
✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot requested changes Apr 28, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bcce5c5 and 530645e.

📒 Files selected for processing (1)
  • src/lib/ClassPreferences.js (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Docker linux/amd64

@dblythy dblythy requested a review from a team April 30, 2025 11:32
@mtrezza mtrezza closed this May 2, 2025
@mtrezza mtrezza reopened this May 2, 2025
@uffizzi-cloud Uffizzi Cloud
Copy link

uffizzi-cloud bot commented May 2, 2025

Uffizzi Ephemeral Environment deployment-63370

⌚ Updated May 02, 2025, 12:03 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2769

📄 View Application Logs etc.

What is Uffizzi? Learn more

@mtrezza mtrezza changed the title fix: Remove filter cache fix: Storing filter in Data browser overwrites filters added in other dashboard instances May 2, 2025
@mtrezza mtrezza changed the title fix: Storing filter in Data browser overwrites filters added in other dashboard instances fix: Saving new filter in Data browser overwrites filters added in other dashboard instances May 2, 2025
@mtrezza mtrezza changed the title fix: Saving new filter in Data browser overwrites filters added in other dashboard instances fix: Saving new filter in data browser overwrites filters added in other dashboard instances May 2, 2025
@mtrezza mtrezza merged commit 46bc154 into parse-community:alpha May 2, 2025
10 of 11 checks passed
parseplatformorg pushed a commit that referenced this pull request May 2, 2025
@semantic-release-bot
chore(release): 7.1.1-alpha.1 [skip ci]
a14973f 
## [7.1.1-alpha.1](7.1.0...7.1.1-alpha.1) (2025-05-02)

### Bug Fixes

* Saving new filter in data browser overwrites filters added in other dashboard instances ([#2769](#2769)) ([46bc154](46bc154))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.1-alpha.1

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza left review comments

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees
No one assigned
Labels
state:released-alpha Released as alpha version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Saving a filter overwrites unloaded filters
3 participants
@dblythy @parseplatformorg @mtrezza