Skip to content

fix: Legacy filters without filterId do not appear in sidebar #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2025
Merged

fix: Legacy filters without filterId do not appear in sidebar #2945

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/components/CategoryList/CategoryList.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,11 @@ export default class CategoryList extends React.Component {
{this.state.openClasses.includes(id) &&
c.filters.map((filterData, index) => {
const { name, filter, id } = filterData;
const url = `${this.props.linkPrefix}${c.name}?filters=${encodeURIComponent(
filter
)}&filterId=${id}`;
// Only include filterId in URL if the filter has an ID (modern filters)
// Legacy filters without ID should work with just the filter content
const url = id
? `${this.props.linkPrefix}${c.name}?filters=${encodeURIComponent(filter)}&filterId=${id}`
: `${this.props.linkPrefix}${c.name}?filters=${encodeURIComponent(filter)}`;
return (
<div key={index} className={styles.childLink}>
<Link
Expand Down
Loading