Skip to content

fix: Prefetch for multiple info panels in data browser doesn't refresh stale cached data #3080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtrezza merged 3 commits into from
Dec 16, 2025
Merged

fix: Prefetch for multiple info panels in data browser doesn't refresh stale cached data #3080

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18afcf1
fix
mtrezza Dec 16, 2025
91b6d81
fix
mtrezza Dec 16, 2025
02d8bc5
Merge branch 'alpha' into fix/batch-nav-prefetch
mtrezza Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions src/dashboard/Data/Browser/DataBrowser.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,8 +957,11 @@ export default class DataBrowser extends React.Component {
const objectsToFetch = [];

if (prevState.panelCount > 1 && selectedObjectId) {
// If the selected object is not in the displayed list, update displayed objects
if (!newDisplayedObjectIds.includes(selectedObjectId)) {
// When batch-navigate is enabled, always rebuild the batch starting from the selected row
// to ensure prefetched data is properly utilized
const shouldRebuildBatch = !newDisplayedObjectIds.includes(selectedObjectId) || prevState.batchNavigate;

if (shouldRebuildBatch) {
const currentIndex = this.props.data?.findIndex(obj => obj.id === selectedObjectId);
if (currentIndex !== -1) {
const { prefetchCache } = prevState;
Expand Down Expand Up @@ -1367,8 +1370,10 @@ export default class DataBrowser extends React.Component {
}

const cache = { ...this.state.prefetchCache };
const now = Date.now();

// Clean up stale entries and track which keys are removed
if (prefetchStale) {
const now = Date.now();
Object.keys(cache).forEach(key => {
if ((now - cache[key].timestamp) / 1000 >= prefetchStale) {
delete cache[key];
Expand All @@ -1379,6 +1384,18 @@ export default class DataBrowser extends React.Component {
this.setState({ prefetchCache: cache });
}

// Helper function to check if an object needs prefetching (missing or stale)
const needsPrefetch = (objectId) => {
if (!Object.prototype.hasOwnProperty.call(cache, objectId)) {
return true;
}
if (prefetchStale) {
const entry = cache[objectId];
return entry && (now - entry.timestamp) / 1000 >= prefetchStale;
}
return false;
};

const history = this.state.selectionHistory;
if (history.length < 3) {
return;
Expand All @@ -1401,7 +1418,7 @@ export default class DataBrowser extends React.Component {
) {
// For each step ahead, prefetch the main object
const mainObjId = this.props.data[c + (i * stepSize)].id;
if (!Object.prototype.hasOwnProperty.call(cache, mainObjId)) {
if (needsPrefetch(mainObjId)) {
this.prefetchObject(mainObjId);
}

Expand All @@ -1410,7 +1427,7 @@ export default class DataBrowser extends React.Component {
const batchStartIndex = c + (i * stepSize);
for (let j = 1; j < panelCount && batchStartIndex + j < this.props.data.length; j++) {
const batchObjId = this.props.data[batchStartIndex + j].id;
if (!Object.prototype.hasOwnProperty.call(cache, batchObjId)) {
if (needsPrefetch(batchObjId)) {
this.prefetchObject(batchObjId);
}
}
Expand Down
Loading