Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add not allowed styles to bulk checkbox. #41

Merged
merged 1 commit into from
Mar 4, 2016
Merged

Add not allowed styles to bulk checkbox. #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion components/DataBrowserHeaderBar/DataBrowserHeaderBar.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@ export default class DataBrowserHeaderBar extends React.Component {
render() {
let { headers, onResize, selected, selectAll, onAddColumn, updateOrdering, readonly, handleDragDrop } = this.props;
let elements = [
// Note: bulk checkbox is disabled as all rows are selected (not just visible ones due to current lazy loading implementation)
// TODO: add bulk checking only visible rows
<div key='check' className={[styles.wrap, styles.check].join(' ')}>
{readonly ? null : <input type='checkbox' disabled={true} checked={false} onChange={(e) => selectAll(e.target.checked)} />}
{readonly ? null : <input className={styles.disabled} type='checkbox' disabled={true} checked={false} onChange={(e) => selectAll(e.target.checked)} />}
</div>
];

Expand Down
4 changes: 4 additions & 0 deletions components/DataBrowserHeaderBar/DataBrowserHeaderBar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,3 +64,7 @@
margin: 0 -4px;
cursor: ew-resize;
}

.disabled {
cursor: not-allowed;
}