Skip to content

Adds set/save to ParseConfig #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2017

Conversation

montymxb
Copy link
Contributor

@montymxb montymxb commented Nov 7, 2017

This adds set/save functionality to ParseConfig, which interacts with the _GlobalConfig collection server-side (of which there should only ever be one instance). Associated tests are added as well.

You can set/save as follows.

// gets the current parse config
$config = new ParseConfig();

// sets a new key/value pair in the config
$config->set('key', 'value');

// saves the current config back to the server
$config->save(); // internally uses the masterKey to save

@montymxb montymxb added this to the 1.4.0 milestone Nov 7, 2017
@codecov
Copy link

codecov bot commented Nov 7, 2017

Codecov Report

Merging #371 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
+ Coverage   98.93%   98.94%   +<.01%     
==========================================
  Files          36       36              
  Lines        3389     3403      +14     
==========================================
+ Hits         3353     3367      +14     
  Misses         36       36
Impacted Files Coverage Δ
src/Parse/ParseConfig.php 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f3dffe...583e657. Read the comment docs.

@montymxb montymxb merged commit bbcec8d into parse-community:master Nov 8, 2017
@montymxb montymxb deleted the update-config branch November 8, 2017 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant