Skip to content

alternate method to remove auth data #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 30, 2019

Conversation

acinader
Copy link
Contributor

Has the added benefit of working with current versions of mongo :).

I copied this from https://github.com/parse-community/parse-server/blob/master/spec/ParseUser.spec.js#L2640

see: #427 (comment)

the added benefit of working with current versions of mongo
@acinader acinader requested a review from flovilmart January 30, 2019 01:31
@flovilmart
Copy link
Contributor

LGTM!

Sent with GitHawk

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dplewis
Copy link
Member

dplewis commented Jan 30, 2019

Can you check that authData->anonymous == null?

Your current test only shows that all authData is gone.

@acinader
Copy link
Contributor Author

@dplewis I don't understand.

I set it to null so it'll be removed, so there's no authData to check.

@dplewis
Copy link
Member

dplewis commented Jan 30, 2019

@acinader nvm, I didn't know this was happening on the back end.

https://github.com/parse-community/parse-server/blob/master/src/RestWrite.js#L1519

Looks good to me!

@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #429 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
+ Coverage   98.92%   98.92%   +<.01%     
==========================================
  Files          38       38              
  Lines        3152     3158       +6     
==========================================
+ Hits         3118     3124       +6     
  Misses         34       34
Impacted Files Coverage Δ
src/Parse/ParseUser.php 98.36% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97d9455...efb120d. Read the comment docs.

@dplewis dplewis merged commit 01de28d into parse-community:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants