-
-
Notifications
You must be signed in to change notification settings - Fork 342
alternate method to remove auth data #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alternate method to remove auth data #429
Conversation
the added benefit of working with current versions of mongo
LGTM! Sent with GitHawk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Can you check that authData->anonymous == null? Your current test only shows that all authData is gone. |
@dplewis I don't understand. I set it to null so it'll be removed, so there's no authData to check. |
@acinader nvm, I didn't know this was happening on the back end. https://github.com/parse-community/parse-server/blob/master/src/RestWrite.js#L1519 Looks good to me! |
Codecov Report
@@ Coverage Diff @@
## master #429 +/- ##
==========================================
+ Coverage 98.92% 98.92% +<.01%
==========================================
Files 38 38
Lines 3152 3158 +6
==========================================
+ Hits 3118 3124 +6
Misses 34 34
Continue to review full report at Codecov.
|
Has the added benefit of working with current versions of mongo :).
I copied this from https://github.com/parse-community/parse-server/blob/master/spec/ParseUser.spec.js#L2640
see: #427 (comment)