Support object->exists() #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acinader
reviewed
Oct 9, 2019
src/Parse/ParseObject.php
Outdated
| public function exists($useMasterKey = false) | ||
| { | ||
| if (!$this->objectId) { | ||
| return; |
acinader
reviewed
Oct 9, 2019
src/Parse/ParseObject.php
Outdated
| $query->get($this->objectId, $useMasterKey); | ||
| return true; | ||
| } catch (Exception $e) { | ||
| if ($e->getMessage() === 'Object not found.') { |
There was a problem hiding this comment.
can this test the error code or number instead of the message string?
Codecov Report
@@ Coverage Diff @@
## master #453 +/- ##
============================================
- Coverage 98% 97.97% -0.03%
- Complexity 1058 1062 +4
============================================
Files 39 39
Lines 2950 2960 +10
============================================
+ Hits 2891 2900 +9
- Misses 59 60 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.