Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server side encryption aes256 #8

Closed
wants to merge 1 commit into from

Conversation

c0nstructer
Copy link

@c0nstructer c0nstructer commented Jun 13, 2017

Added plain aes256 encryption, written (copy pasted your test and modified).
Basic usage:

var fsAdapter = new FileSystemAdapter({
    encrypt: true,
    secretKey: 'stefan'
});

@codecov
Copy link

codecov bot commented Jun 13, 2017

Codecov Report

Merging #8 into master will decrease coverage by 5.55%.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage   83.87%   78.31%   -5.56%     
==========================================
  Files           1        1              
  Lines          62       83      +21     
  Branches       12       18       +6     
==========================================
+ Hits           52       65      +13     
- Misses         10       18       +8
Impacted Files Coverage Δ
index.js 78.31% <70%> (-5.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32b1e0c...c73ece5. Read the comment docs.

@flovilmart
Copy link
Contributor

I really appreciate the effort on this PR, and that seems highly valuable. Could we use the native crypto libraries instead of node-cipher as it doesn't look heavily supported or popular and we try to limit dependencies over 3rd party libraries when possible.

@c0nstructer
Copy link
Author

c0nstructer commented Jun 13, 2017 via email

@cbaker6
Copy link
Contributor

cbaker6 commented Oct 23, 2020

@davimacedo you can close this PR as #15 includes it's fixes and more

@davimacedo davimacedo closed this Oct 23, 2020
@ghost
Copy link

ghost commented Oct 23, 2020

Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page.

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants