Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
 into ldap-auth-support
  • Loading branch information
brodo committed Nov 20, 2019
2 parents 6c97b00 + 5ed0885 commit feec168
Show file tree
Hide file tree
Showing 6 changed files with 264 additions and 6 deletions.
150 changes: 150 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

40 changes: 38 additions & 2 deletions spec/CloudCode.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2219,10 +2219,14 @@ describe('afterFind hooks', () => {
it('should validate triggers correctly', () => {
expect(() => {
Parse.Cloud.beforeSave('_Session', () => {});
}).toThrow('Triggers are not supported for _Session class.');
}).toThrow(
'Only the afterLogout trigger is allowed for the _Session class.'
);
expect(() => {
Parse.Cloud.afterSave('_Session', () => {});
}).toThrow('Triggers are not supported for _Session class.');
}).toThrow(
'Only the afterLogout trigger is allowed for the _Session class.'
);
expect(() => {
Parse.Cloud.beforeSave('_PushStatus', () => {});
}).toThrow('Only afterSave is allowed on _PushStatus');
Expand All @@ -2247,6 +2251,22 @@ describe('afterFind hooks', () => {
expect(() => {
Parse.Cloud.beforeLogin('SomeClass', () => {});
}).toThrow('Only the _User class is allowed for the beforeLogin trigger');
expect(() => {
Parse.Cloud.afterLogout(() => {});
}).not.toThrow();
expect(() => {
Parse.Cloud.afterLogout('_Session', () => {});
}).not.toThrow();
expect(() => {
Parse.Cloud.afterLogout('_User', () => {});
}).toThrow(
'Only the _Session class is allowed for the afterLogout trigger.'
);
expect(() => {
Parse.Cloud.afterLogout('SomeClass', () => {});
}).toThrow(
'Only the _Session class is allowed for the afterLogout trigger.'
);
});

it('should skip afterFind hooks for aggregate', done => {
Expand Down Expand Up @@ -2436,6 +2456,22 @@ describe('beforeLogin hook', () => {
done();
});

it('should trigger afterLogout hook on logout', async done => {
let userId;
Parse.Cloud.afterLogout(req => {
expect(req.object.className).toEqual('_Session');
expect(req.object.id).toBeDefined();
const user = req.object.get('user');
expect(user).toBeDefined();
userId = user.id;
});

const user = await Parse.User.signUp('user', 'pass');
await Parse.User.logOut();
expect(user.id).toBe(userId);
done();
});

it('should have expected data in request', async done => {
Parse.Cloud.beforeLogin(req => {
expect(req.object).toBeDefined();
Expand Down
18 changes: 18 additions & 0 deletions spec/ParseUser.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -1523,6 +1523,24 @@ describe('Parse.User testing', () => {
done();
});

it('logout with provider should call afterLogout trigger', async done => {
const provider = getMockFacebookProvider();
Parse.User._registerAuthenticationProvider(provider);

let userId;
Parse.Cloud.afterLogout(req => {
expect(req.object.className).toEqual('_Session');
expect(req.object.id).toBeDefined();
const user = req.object.get('user');
expect(user).toBeDefined();
userId = user.id;
});
const user = await Parse.User._logInWith('facebook');
await Parse.User.logOut();
expect(user.id).toBe(userId);
done();
});

it('link with provider', async done => {
const provider = getMockFacebookProvider();
Parse.User._registerAuthenticationProvider(provider);
Expand Down
12 changes: 12 additions & 0 deletions src/Routers/UsersRouter.js
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,7 @@ export class UsersRouter extends ClassesRouter {
records.results[0].objectId
)
.then(() => {
this._runAfterLogoutTrigger(req, records.results[0]);
return Promise.resolve(success);
});
}
Expand All @@ -311,6 +312,17 @@ export class UsersRouter extends ClassesRouter {
return Promise.resolve(success);
}

_runAfterLogoutTrigger(req, session) {
// After logout trigger
maybeRunTrigger(
TriggerTypes.afterLogout,
req.auth,
Parse.Session.fromJSON(Object.assign({ className: '_Session' }, session)),
null,
req.config
);
}

_throwOnBadEmailConfig(req) {
try {
Config.validateEmailConfiguration({
Expand Down
35 changes: 35 additions & 0 deletions src/cloud-code/Parse.Cloud.js
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,41 @@ ParseCloud.beforeLogin = function(handler) {
);
};

/**
*
* Registers the after logout function.
*
* **Available in Cloud Code only.**
*
* This function is triggered after a user logs out.
*
* ```
* Parse.Cloud.afterLogout((request) => {
* // code here
* })
*
* ```
*
* @method afterLogout
* @name Parse.Cloud.afterLogout
* @param {Function} func The function to run after a logout. This function can be async and should take one parameter a {@link Parse.Cloud.TriggerRequest};
*/
ParseCloud.afterLogout = function(handler) {
let className = '_Session';
if (typeof handler === 'string' || isParseObjectConstructor(handler)) {
// validation will occur downstream, this is to maintain internal
// code consistency with the other hook types.
className = getClassName(handler);
handler = arguments[1];
}
triggers.addTrigger(
triggers.Types.afterLogout,
className,
handler,
Parse.applicationId
);
};

/**
* Registers an after save function.
*
Expand Down
Loading

0 comments on commit feec168

Please sign in to comment.