Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External File Adapter Dependencies #1434

Closed
mamaso opened this issue Apr 8, 2016 · 2 comments
Closed

External File Adapter Dependencies #1434

mamaso opened this issue Apr 8, 2016 · 2 comments

Comments

@mamaso
Copy link

mamaso commented Apr 8, 2016

Hey, noticed that the GCS file adapter was moved to devDependencies in this commit 1eb2a87

I like the opt-in approach to these dependencies for production parse servers, any similar plans for S3 / ParseFS adapters?

@drew-gross
Copy link
Contributor

The reason for that one is because the one of the transitive dependencies needed to compile native code and required more than 1GB of RAM to do so, causing install failures on AWS micro instances. I agree that it's a better model to have the dependencies be opt-in, but thats also a breaking change and I'm not sure if the benefit of the breaking change justifies the cost to everyone else, like it did with the GCS adapter.

@mamaso
Copy link
Author

mamaso commented Apr 11, 2016

Makes sense, not worth the pain of the breaking change unless if there are extenuating circumstances like native module failures. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants