[PROPOSAL] Deprecate fully useMasterKey and Parse.User.currentUser()

[flovilmart]

As those functions are misleading and unavailable in Cloud Code, I suggest we replace those implementations by implementations that would log a warning in the 1st place and throw an exception later on.

The warning could have a link to the CloudCode migration notes

[benishak]

why ? we still using Parse.Cloud.useMasterKey() and Parse.Cloud.HttpRequest and they are working fine, why deprecate them?

[bohemima]

@benishak, Parse.Cloud.useMasterKey does not work and you should be sending the useMasterKey option in every individual save/find/etc options instead.

HttpRequest is not being deprecated afaik but you should consider using the "request" module instead now that you can use third party node modules.

[hramos]

Agree with this. IIRC, the current state is that people who port their Cloud Code over without consulting the migration notes may assume their code will continue working as-is as these methods fail silently.

[flovilmart]

I've planned that for 2.3.0, to make it breaking/throw error in that case.

Do anyone have any voice to raise that those 2 functions will throw an exception starting 2.3.0

[benishak]

I'm not sure but because when we migrated we almost refactor the whole cloud code and when we were getting 'permission denied use Master Key' we solved it by calling Parse.Cloud.useMasterkey(). It worked almost everywhere except with Parse.Push.send we had to use { useMasterkey : true }

[flovilmart]

even a better reason to prevent the usage of Parse.Cloud.useMasterKey() as it may have horrible side effects with concurrent request... you should use {useMasterKey: true} everywhere you need it.

See: https://github.com/ParsePlatform/parse-server/wiki/Compatibility-with-Hosted-Parse#master-key-must-be-passed-explicitly

Maybe we haven't been explicit enough about that, an additional reason to enforce it strongly,

[benishak]

I'm using now the latest version and have a class wich has CLP and ACL set to Master key only and have a defined Cloud function

Parse.Cloud.define('verifyemail', function(req, res) {
      Parse.Cloud.useMasterkey()
      ..
      ..
});

It stills working,

I also have another Cloud Function which calls Parse.Cloud.HttpRequest and is still working
How and why?

[flovilmart]

when you call Parse.Cloud.useMasterkey() that makes all future calls use the masterKey:

https://github.com/ParsePlatform/Parse-SDK-JS/blob/2956decbe54f2cf6d2c17ff1b4d8db98327410d6/src/Parse.js#L148

Basically, calling it once would probably make all future calls use the masterKey which is why we highly recommend you don't use Parse.Cloud.useMasterKey().

And I never mentioned anything about httpRequest, but Parse.User.current()

[cherukumilli]

@flovilmart @hramos
Will the Parse JS SDK continue to support Parse.User.current()?
If not, is there a better way to retrieve the currently logged in ParseUser with a valid session, either from memory or localStorage on the client side.

[flovilmart]

@cherukumilli yes in the client side SDK that's all good, not on the serverside though... (because of the concurrency and global state of ParseSDK)

[acinader]

i think this is a great idea that could be helpful to folks migrating (everyone's all done, right?).
👍

[flovilmart]

It seems that Parse.User.current() should always return null anyway: https://github.com/ParsePlatform/Parse-SDK-JS/blob/2956decbe54f2cf6d2c17ff1b4d8db98327410d6/src/ParseUser.js#L26