Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds depreciation notes for Parse.Cloud.useMasterKey() #3204

Merged
merged 3 commits into from
Dec 7, 2016
Merged

Adds depreciation notes for Parse.Cloud.useMasterKey() #3204

merged 3 commits into from
Dec 7, 2016

Conversation

flovilmart
Copy link
Contributor

@flovilmart flovilmart commented Dec 7, 2016 •
edited
Loading

replaces by noop that logs a link to the migration notes.

In 2.4.0, we should throw exceptions.

Fixes: #2633

acinader
acinader approved these changes Dec 7, 2016
View reviewed changes
Copy link
Contributor

@acinader acinader left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi, you can use // eslint-disable-next-line instead and then you don't have to re-enable

not sure how i missed that when looking for how to do this.

@flovilmart
Copy link
Contributor Author

Ahahha OK thanks!

@facebook-github-bot
Copy link

@flovilmart updated the pull request - view changes

@facebook-github-bot
Copy link

@flovilmart updated the pull request - view changes

@flovilmart flovilmart changed the title Adds depreciation notes for Parse.Cloud.useMasterKey(), Adds depreciation notes for Parse.Cloud.useMasterKey() Dec 7, 2016
@flovilmart flovilmart merged commit 025e7a3 into master Dec 7, 2016
@flovilmart flovilmart deleted the issue-2633 branch December 7, 2016 23:35
Jcarlosjunior pushed a commit to back4app/parse-server that referenced this pull request Dec 13, 2016
@flovilmart @Jcarlosjunior
Adds depreciation notes for Parse.Cloud.useMasterKey(), (parse-commun…
f0d3ca8 
…ity#3204)

Adds depreciation notes for Parse.Cloud.useMasterKey()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acinader acinader acinader approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flovilmart @facebook-github-bot @acinader