Skip to content

Parse.Object.saveAll Failing When PARSE_SERVER_ENABLE_EXPERIMENTAL_DIRECT_ACCESS=0 #3197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
listingboat opened this issue Dec 7, 2016 · 13 comments

Comments

@listingboat
Copy link

listingboat commented Dec 7, 2016

Using parse-server 2.2.5 with Node 7.2

I've completed the refactor to remove Parse.Cloud.useMasterKey() and use {userMasterKey:true} in the save and saveAll calls.

This all works fine when PARSE_SERVER_ENABLE_EXPERIMENTAL_DIRECT_ACCESS=1

If I turn it off, then the saveAll(objectsToSave, {useMasterKey: true}), I get this error:

error: Error handling request: ParseError {
  code: 107,
  message: 'cannot route PUT \\classes\\_User\\01dJFUbNLz' } code=107, message=cannot route PUT \classes\_User\01dJFUbNLz
URL: /parse/batch
@bmcminn
Copy link

bmcminn commented Dec 7, 2016

OS: Win7 x64 Enterprise
Node: 7.2.0
Parse: ~1.9.1
Parse Server: ^2.2.24

Been going over this issue with @listingboat this morning and it seems the query path separator Parse Server is using on Windows is using the native Windows filesystem path separator (\\) as opposed to the / path separator.

Is there a spec that defines how the Parse direct access query handler resolves query paths? because this is a behavior I'm used to seeing in Node's filesystem path methods.

@listingboat
Copy link
Author

This was fixed with #3138. But, apparently not released yet?

It was an issue with using path on Windows.

@flovilmart
Copy link
Contributor

Should be released soon.

@flovilmart
Copy link
Contributor

In the meantime you can probably point yourself to parseplatform/parse-server#latest

@listingboat
Copy link
Author

Thanks @flovilmart !

@flovilmart
Copy link
Contributor

@listingboat is it working correctly with the latest release?

@bmcminn
Copy link

bmcminn commented Dec 12, 2016

@flovilmart Everything seems to be working just fine :)

@flovilmart
Copy link
Contributor

flovilmart commented Dec 12, 2016

that's great, I'm thinking of putting this as the default for the next minor (2.4.0) release. Your feedback is highly valuable

@listingboat
Copy link
Author

listingboat commented Dec 12, 2016

Yes, this issue affected windows only which is our development platform, not our production platform which is Linux on Heroku.

We pushed production with this flag on and haven't seen any issues today.

@flovilmart
Copy link
Contributor

that's great, any noticeable performance improvement with CloudCode?

@listingboat
Copy link
Author

I ran a simple JMeter test against my local instance with PARSE_SERVER_ENABLE_EXPERIMENTAL_DIRECT_ACCESS set to 0 then again with it set to 1. requests seem to be cut in half. On larger queries, the time is cut down up to 500%.

@flovilmart
Copy link
Contributor

Holy molly.... That's cool

@stale
Copy link

stale bot commented Sep 18, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 18, 2018
@stale stale bot closed this as completed Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants