-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Parse.Object.saveAll Failing When PARSE_SERVER_ENABLE_EXPERIMENTAL_DIRECT_ACCESS=0 #3197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Been going over this issue with @listingboat this morning and it seems the query path separator Parse Server is using on Windows is using the native Windows filesystem path separator ( Is there a spec that defines how the Parse direct access query handler resolves query paths? because this is a behavior I'm used to seeing in Node's filesystem path methods. |
This was fixed with #3138. But, apparently not released yet? It was an issue with using path on Windows. |
Should be released soon. |
In the meantime you can probably point yourself to |
Thanks @flovilmart ! |
@listingboat is it working correctly with the latest release? |
@flovilmart Everything seems to be working just fine :) |
that's great, I'm thinking of putting this as the default for the next minor (2.4.0) release. Your feedback is highly valuable |
Yes, this issue affected windows only which is our development platform, not our production platform which is Linux on Heroku. We pushed production with this flag on and haven't seen any issues today. |
that's great, any noticeable performance improvement with CloudCode? |
I ran a simple JMeter test against my local instance with PARSE_SERVER_ENABLE_EXPERIMENTAL_DIRECT_ACCESS set to 0 then again with it set to 1. requests seem to be cut in half. On larger queries, the time is cut down up to 500%. |
Holy molly.... That's cool |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Using parse-server 2.2.5 with Node 7.2
I've completed the refactor to remove
Parse.Cloud.useMasterKey()
and use{userMasterKey:true}
in the save and saveAll calls.This all works fine when
PARSE_SERVER_ENABLE_EXPERIMENTAL_DIRECT_ACCESS=1
If I turn it off, then the
saveAll(objectsToSave, {useMasterKey: true})
, I get this error:The text was updated successfully, but these errors were encountered: