Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CI check "NPM lock file version" and regenerate package-lock.json as v2 #8274

Closed
3 tasks done
Tracked by #8225
mtrezza opened this issue Nov 2, 2022 · 6 comments · Fixed by #8285
Closed
3 tasks done
Tracked by #8225

Remove CI check "NPM lock file version" and regenerate package-lock.json as v2 #8274

mtrezza opened this issue Nov 2, 2022 · 6 comments · Fixed by #8285
Labels
block:major Needs to be resolved before next major release; remove label afterwards state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:feature New feature or improvement of existing feature

Comments

@mtrezza
Copy link
Member

mtrezza commented Nov 2, 2022 •
edited
Loading

New Feature / Enhancement Checklist

Current Limitation

Removal of Node 12 support allows to safely move to package-lock.json v2.

Feature / Enhancement Description

Remove CI check "NPM lock file version" and regenerate package-lock.json as v2

Example Use Case

n/a

Alternatives / Workarounds

n/a
@mtrezza mtrezza mentioned this issue Nov 2, 2022
Closed
31 tasks
@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 2, 2022 •
edited
Loading

Thanks for opening this issue!

  • 🎉 We are excited about your ideas for improvement!

@mtrezza mtrezza changed the title Remove CI check "NPM lock file version" and commit using package-lock.json v2 Remove CI check "NPM lock file version" and regenerate package-lock.json v2 Nov 2, 2022
@mtrezza mtrezza changed the title Remove CI check "NPM lock file version" and regenerate package-lock.json v2 Remove CI check "NPM lock file version" and regenerate package-lock.json as v2 Nov 2, 2022
@mtrezza mtrezza added type:feature New feature or improvement of existing feature block:major Needs to be resolved before next major release; remove label afterwards state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message labels Nov 2, 2022
@dblythy dblythy mentioned this issue Nov 3, 2022
Merged
4 tasks
@dblythy
Copy link
Member

dblythy commented Nov 6, 2022

I think lockfile v2 starts with npm 7, which is shipped with node > 15

Screen Shot 2022-11-06 at 3 38 45 pm

@mtrezza
Copy link
Member Author

mtrezza commented Nov 6, 2022 •
edited
Loading

So we stick with v1 until we remove Node 14 support in PS7? If technically possible, an argument for switching to v2 (since it's backwards compatible with v1) could be to reduce the install time on Node >=16.

@mtrezza mtrezza mentioned this issue Dec 21, 2022
Closed
3 tasks
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0-alpha.17

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Dec 22, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jan 31, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
block:major Needs to be resolved before next major release; remove label afterwards state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:feature New feature or improvement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Upgrade Node Package Manager lock file package-lock.json to version 2 dblythy/parse-server
3 participants
@dblythy @mtrezza @parseplatformorg