-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
refactor: Bump redis from 4.7.0 to 5.10.0 #10009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Bump redis from 4.7.0 to 5.10.0 #10009
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Co-authored-by: mtrezza <5673677+mtrezza@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot try again |
653052a
into
dependabot/npm_and_yarn/redis-5.10.0
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dependabot/npm_and_yarn/redis-5.10.0 #10009 +/- ##
=======================================================================
Coverage ? 92.53%
=======================================================================
Files ? 190
Lines ? 15468
Branches ? 176
=======================================================================
Hits ? 14314
Misses ? 1142
Partials ? 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request
Issue
Dependency upgrade from redis 4.7.0 to 5.10.0 (major version bump).
Approach
Updated codebase to address redis v5 breaking changes per official migration guide:
Connection lifecycle: Replaced deprecated
client.quit()withclient.close()RedisCacheAdapterandParseLiveQueryServerQUITcommand was deprecated in Redis 7.2 and removed from node-redis v5Client options: Removed unsupported
no_ready_checkoption fromRedisPubSubOther v5 breaking changes (scan iterators, boolean→number types, command options API) don't affect current usage patterns.
Tasks
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.