Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 17, 2026

Pull Request

Issue

Dependency upgrade from redis 4.7.0 to 5.10.0 (major version bump).

Approach

Updated codebase to address redis v5 breaking changes per official migration guide:

  • Connection lifecycle: Replaced deprecated client.quit() with client.close()

    • Updated in RedisCacheAdapter and ParseLiveQueryServer
    • The QUIT command was deprecated in Redis 7.2 and removed from node-redis v5
  • Client options: Removed unsupported no_ready_check option from RedisPubSub

    • No longer needed in v5 architecture
    • Updated corresponding test expectations

Other v5 breaking changes (scan iterators, boolean→number types, command options API) don't affect current usage patterns.

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@coderabbitai
Copy link

coderabbitai bot commented Jan 17, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@parseplatformorg
Copy link
Contributor

parseplatformorg commented Jan 17, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Co-authored-by: mtrezza <5673677+mtrezza@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 17, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • downloads.mongodb.org
    • Triggering command: /usr/local/bin/node node /home/REDACTED/work/parse-server/parse-server/node_modules/.bin/mongodb-REDACTED exec -t standalone --version 8.0.4 -- --port 27017 -- npm run testonly spec/RedisPubSub.spec.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update redis from 4.7.0 to 5.10.0 refactor: Bump redis from 4.7.0 to 5.10.0 Jan 17, 2026
Copilot AI requested a review from mtrezza January 17, 2026 20:19
@mtrezza mtrezza marked this pull request as ready for review January 17, 2026 20:19
@mtrezza
Copy link
Member

mtrezza commented Jan 17, 2026

@copilot try again

@mtrezza mtrezza merged commit 653052a into dependabot/npm_and_yarn/redis-5.10.0 Jan 17, 2026
19 of 21 checks passed
@mtrezza mtrezza deleted the copilot/sub-pr-9994 branch January 17, 2026 20:21
Copilot stopped work on behalf of mtrezza due to an error January 17, 2026 20:22
@codecov
Copy link

codecov bot commented Jan 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (dependabot/npm_and_yarn/redis-5.10.0@61e4eff). Learn more about missing BASE report.

Additional details and impacted files
@@                           Coverage Diff                           @@
##             dependabot/npm_and_yarn/redis-5.10.0   #10009   +/-   ##
=======================================================================
  Coverage                                        ?   92.53%           
=======================================================================
  Files                                           ?      190           
  Lines                                           ?    15468           
  Branches                                        ?      176           
=======================================================================
  Hits                                            ?    14314           
  Misses                                          ?     1142           
  Partials                                        ?       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants