Skip to content

Improvements in REST calls #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2016
Merged

Improvements in REST calls #1066

merged 3 commits into from
Mar 17, 2016

Conversation

flovilmart
Copy link
Contributor

  • Returns all valid __op on PUT and POST (Increment, Add, AddUnique, Remove)
  • Sanitizes the results when running increments in hooks

fixes #1037
fixes #1031

@codecov-io
Copy link

Current coverage is 91.69%

Merging #1066 into master will increase coverage by +0.07% as of 3ba5d2e

@@            master   #1066   diff @@
======================================
  Files           73      74     +1
  Stmts         4442    4465    +23
  Branches       889     894     +5
  Methods          0       0       
======================================
+ Hit           4070    4094    +24
  Partial         10      10       
+ Missed         362     361     -1

Review entire Coverage Diff as of 3ba5d2e

Powered by Codecov. Updated on successful CI builds.

@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@flovilmart flovilmart changed the title Returns modifications of all valid ops on PUT Improvements in REST calls Mar 17, 2016
@flovilmart flovilmart force-pushed the flovilmart.returnsFullModificationsForREST branch from ae0dffb to e270964 Compare March 17, 2016 04:04
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@flovilmart flovilmart mentioned this pull request Mar 17, 2016
Closed
flovilmart added a commit that referenced this pull request Mar 17, 2016
@flovilmart
Merge pull request #1066 from ParsePlatform/flovilmart.returnsFullMod…
3837d33 
…ificationsForREST

Improvements in REST calls
@flovilmart flovilmart merged commit 3837d33 into master Mar 17, 2016
@flovilmart flovilmart deleted the flovilmart.returnsFullModificationsForREST branch March 17, 2016 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BeforeSave changes are not propagated into the result of a PUT operation with REST API .save() doesn't trigger beforeSave and afterSave
4 participants
@flovilmart @codecov-io @facebook-github-bot @gfosco