Clear the session-user cache when changing _User objects

[gfosco]

For issue #1062

[codecov-io]

Current coverage is 91.67%

Merging #1072 into master will increase coverage by +0.01% as of a08e2c2

@@            master   #1072   diff @@
======================================
  Files           74      74       
  Stmts         4452    4454     +2
  Branches       890     891     +1
  Methods          0       0       
======================================
+ Hit           4081    4083     +2
  Partial         10      10       
  Missed         361     361       

Review entire Coverage Diff as of a08e2c2

Powered by Codecov. Updated on successful CI builds.

[flovilmart]

Also when we have the oauthLogin shortcut?

[gfosco]

Not sure what you mean here..

[flovilmart]

I mean when we do the login shortcut with oAuth, we go through that method. If there is a cached token for the found user, we should destroy it too to remove any wrong possible state, the same way we remove it upon user login

[mullwaden]

Thanks @gfosco !

Does it also solve for the following case where we have a user with a pointer to a second object (privateData)?

• some change is made to the user such that the privateData is included in the cache (this seems to happen)
• I make a change to the privateData object (without touching the user)
• I create a new object card details (on which I use cardDetails.set('user', request.user)

Will there be an old version of the "privateData" object tagging along with the cardDetails?

[gfosco]

I don't think it would solve that case, no. I think you should perform a fetch on any included objects.

Since we store the user cache based on sessionToken, it also wouldn't support changes to that user made by the masterKey. We'd have to search through all the sessions to invalidate any matching that user...