Add Windows Support (bcrypt > bcrypt-node) #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
felixrieseberg
commented
Feb 1, 2016
felixrieseberg
commented
- This commit replaces bcrypt with bcrypt-node, which has the same functionality as bcrypy - except that it is a pure Node implementation. This change is required to run parse-server on Windows (one can get bcrypt to compile on Windows, but it requires a few Gigabytes of dependencies).
felixrieseberg
changed the title
|
I see |
felixrieseberg
force-pushed
the
bcrypt-node
branch
from
fae8861 to
1aa61eb
Compare
|
Good point - going with bcrypt-nodejs might be the more popular choice. We at Microsoft did a quick check, either one would allow peeps to run this without any worries (I believe they're both using bcrypt.js underneath). I updated they PR. |
| @@ -1,6 +1,6 @@ | |||
| // Tools for encrypting and decrypting passwords. | |||
| // Basically promise-friendly wrappers for bcrypt. | |||
| var bcrypt = require('bcrypt'); | |||
| var bcrypt = require('bcrypt-node'); | |||
- This commit replaces bcrypt with bcrypt-node, which has the same functionality as bcrypy - except that it is a pure Node implementation. This change is required to run parse-server on Windows (one can get bcrypt to compile on Windows, but it requires a few Gigabytes of dependencies).
felixrieseberg
force-pushed
the
bcrypt-node
branch
from
1aa61eb to
1cddbb0
Compare
|
@gfosco: Thanks for the catch. |
gfosco
added a commit
that referenced
this pull request
Feb 1, 2016
Add Windows Support (bcrypt > bcrypt-node)
|
👍 |
|
@gfosco do you have plans to release an update to npm soon? Would be great to have this change published! |
|
Yeah, but some tests are failing right now.... Once I fix it will release a new version. |
bernhardharrer
pushed a commit
to bernhardharrer/parse-server
that referenced
this pull request
Feb 22, 2017
Update package.json
This was referenced Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.